From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, paulus@samba.org,
davem@davemloft.net, fweisbec@gmail.com, robert.richter@amd.com,
perfmon2-devel@lists.sf.net, eranian@gmail.com
Subject: Re: [PATCH] perf_events: fix bogus warn_on(_once) in perf_prepare_sample()
Date: Thu, 08 Apr 2010 23:23:04 +0200 [thread overview]
Message-ID: <1270761784.20295.3161.camel@laptop> (raw)
In-Reply-To: <g2rbd4cb8901004081414l505e6b04td902794f381224af@mail.gmail.com>
On Thu, 2010-04-08 at 23:14 +0200, Stephane Eranian wrote:
> On Thu, Apr 8, 2010 at 11:11 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Thu, 2010-04-08 at 23:08 +0200, Stephane Eranian wrote:
> >>
> >> Are you suggesting you add some padding the PEBS raw sample you
> >> return as PERF_SAMPLE_RAW? Then you need to define what RAW
> >> actually means? Seems here, it would mean more than what the
> >> HW returns.
> >
> > Well, RAW doesn't mean anything much at all, its really a fugly pass
> > some crap around thing.
> >
> > So yeah, adding padding seems just fine.
> >
> I would rather see size as u64. Who's using raw today anyway?
the tracepoint stuff does
next prev parent reply other threads:[~2010-04-08 21:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 20:45 [PATCH] perf_events: fix bogus warn_on(_once) in perf_prepare_sample() Stephane Eranian
2010-04-08 20:55 ` Peter Zijlstra
2010-04-08 21:03 ` Peter Zijlstra
2010-04-08 21:18 ` Stephane Eranian
2010-04-08 21:24 ` Peter Zijlstra
2010-04-08 21:33 ` Stephane Eranian
2010-04-08 21:08 ` Stephane Eranian
2010-04-08 21:11 ` Peter Zijlstra
2010-04-08 21:14 ` Stephane Eranian
2010-04-08 21:17 ` Frederic Weisbecker
2010-04-08 21:22 ` Stephane Eranian
2010-04-08 21:42 ` Frederic Weisbecker
2010-04-08 21:46 ` Frederic Weisbecker
2010-04-08 21:23 ` Peter Zijlstra [this message]
2010-04-08 21:12 ` Peter Zijlstra
2010-04-08 21:15 ` Peter Zijlstra
2010-04-08 21:29 ` Stephane Eranian
2010-04-08 21:42 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270761784.20295.3161.camel@laptop \
--to=peterz@infradead.org \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox