Re: [PATCH 0/2] tracing: lost events changes

[Steven Rostedt <rostedt@goodmis.org>]

On Wed, 2010-04-14 at 15:00 +0200, Jiri Olsa wrote:
> hi,
> 
> I noticed LOST EVENTS messages in the iterator "trace" file.
> According to the comment from commit bc21b478 this won't work.
> 
> <comment>
>     Note, it does not work with the iterator "trace" file, since it requires
>     the use of consuming the page from the ring buffer to determine how many
>     events were lost, which the iterator does not do.
> </comment>
> 
> I'm not sure the attached fix (2/2) is on the right place,
> but stops the LOST EVENTS display for iterator "trace" file.
> 

This has already been fixed by Lai:

http://marc.info/?l=linux-kernel&m=127045871922996

And I asked Ingo to pull it here:

http://marc.info/?l=linux-kernel&m=127048065715829

> I also added option to control the LOST EVENTS display (1/2) if needed.

Hmm, I'm not sure we want to control it. It is very useful information.

Thanks,

-- Steve

> 
> attached patches:
> - 1/2 - adding lost-events option
> - 2/2 - supress lost events message for iterator "trace"
> 
> 
> wbr,
> jirka
> ---
>  kernel/trace/trace.c |   24 ++++++++++++++----------
>  kernel/trace/trace.h |    1 +
>  2 files changed, 15 insertions(+), 10 deletions(-)