From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: David Howells <dhowells@redhat.com>
Cc: paulmck@linux.vnet.ibm.com, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: RCU-isms in fs/nfs/delegation.c
Date: Tue, 20 Apr 2010 08:29:06 -0400 [thread overview]
Message-ID: <1271766546.25129.76.camel@localhost.localdomain> (raw)
In-Reply-To: <32174.1271753314@redhat.com>
On Tue, 2010-04-20 at 09:48 +0100, David Howells wrote:
> Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
>
> > + nfs_inode_set_delegation(inode, cred, res);
> > + }
> > +out:
> > + rcu_read_unlock();
> > }
>
> I think this is wrong. nfs_inode_set_delegation() may sleep as it calls
> kmalloc() with GFP_KERNEL - but you still have the RCU read lock held. I
> think you need to drop the RCU read lock before calling it.
>
> David
Agreed. Thanks for the review...
Cheers
Trond
next prev parent reply other threads:[~2010-04-20 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 15:33 RCU-isms in fs/nfs/delegation.c David Howells
2010-04-19 17:32 ` Trond Myklebust
2010-04-20 8:48 ` David Howells
2010-04-20 12:29 ` Trond Myklebust [this message]
2010-04-20 12:49 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271766546.25129.76.camel@localhost.localdomain \
--to=trond.myklebust@netapp.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox