From: Peter Zijlstra <peterz@infradead.org>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
"eranian@gmail.com" <eranian@gmail.com>,
"Gary.Mohr@Bull.com" <Gary.Mohr@bull.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
arjan@linux.intel.com, "Zhang,
Yanmin" <yanmin_zhang@linux.intel.com>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH 1/4] perf: core, add group scheduling transactional APIs
Date: Thu, 22 Apr 2010 10:24:59 +0200 [thread overview]
Message-ID: <1271924699.1776.316.camel@laptop> (raw)
In-Reply-To: <1271922662.30535.107.camel@minggr.sh.intel.com>
On Thu, 2010-04-22 at 15:51 +0800, Lin Ming wrote:
> + if (pmu->commit_txn) {
> + ret = pmu->commit_txn(pmu);
> + if (!ret) {
> + if (pmu->stop_txn)
> + pmu->stop_txn(pmu);
> +
> + return 0;
> + }
> + }
I think we can mandate that if one of the _txn methods is available,
they all are, it would be weird otherwise.
next prev parent reply other threads:[~2010-04-22 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 7:51 [RFC][PATCH 1/4] perf: core, add group scheduling transactional APIs Lin Ming
2010-04-22 8:24 ` Peter Zijlstra [this message]
2010-04-22 9:19 ` Lin Ming
2010-04-22 17:31 ` Frederic Weisbecker
2010-04-23 2:08 ` Lin Ming
2010-04-23 2:12 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271924699.1776.316.camel@laptop \
--to=peterz@infradead.org \
--cc=Gary.Mohr@bull.com \
--cc=arjan@linux.intel.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox