linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 2/9] perf: Fix initialization bug in parse_single_tracepoint_event()
Date: Sat, 24 Apr 2010 04:05:35 +0200	[thread overview]
Message-ID: <1272074742-3654-3-git-send-regression-fweisbec@gmail.com> (raw)
In-Reply-To: <1272074742-3654-1-git-send-regression-fweisbec@gmail.com>

From: Stephane Eranian <eranian@google.com>

The parse_single_tracepoint_event() was setting some attributes
before it validated the event was indeed a tracepoint event. This
caused problems with other initialization routines like in the
builtin-top.c module whereby sample_period is not set if not 0.

Signed-off-by: Stephane Eranian <eranian@google.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>
LKML-Reference: <4bcf232b.698fd80a.6fbe.ffffb737@mx.google.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
 tools/perf/util/parse-events.c |   13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 3b4ec67..600d327 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -418,12 +418,6 @@ parse_single_tracepoint_event(char *sys_name,
 	u64 id;
 	int fd;
 
-	attr->sample_type |= PERF_SAMPLE_RAW;
-	attr->sample_type |= PERF_SAMPLE_TIME;
-	attr->sample_type |= PERF_SAMPLE_CPU;
-
-	attr->sample_period = 1;
-
 	snprintf(evt_path, MAXPATHLEN, "%s/%s/%s/id", debugfs_path,
 		 sys_name, evt_name);
 
@@ -442,6 +436,13 @@ parse_single_tracepoint_event(char *sys_name,
 	attr->type = PERF_TYPE_TRACEPOINT;
 	*strp = evt_name + evt_length;
 
+	attr->sample_type |= PERF_SAMPLE_RAW;
+	attr->sample_type |= PERF_SAMPLE_TIME;
+	attr->sample_type |= PERF_SAMPLE_CPU;
+
+	attr->sample_period = 1;
+
+
 	return EVT_HANDLED;
 }
 
-- 
1.6.2.3


  parent reply	other threads:[~2010-04-24  2:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-24  2:05 [GIT PULL] perf tools updates Frederic Weisbecker
2010-04-24  2:05 ` [PATCH 1/9] perf lock: Fix state machine to recognize lock sequence Frederic Weisbecker
2010-04-24 10:43   ` [PATCH] perf lock: add "info" subcommand for dumping misc information Hitoshi Mitake
2010-04-24 10:46     ` Hitoshi Mitake
2010-04-24 10:46   ` [PATCH v2] " Hitoshi Mitake
2010-04-24 13:41     ` Frederic Weisbecker
2010-04-30 18:49     ` Frederic Weisbecker
2010-05-03  5:11       ` Hitoshi Mitake
2010-05-03  5:12         ` [PATCH v3] " Hitoshi Mitake
2010-05-05 21:10           ` Frederic Weisbecker
2010-05-06  9:31             ` Hitoshi Mitake
2010-05-06  9:32               ` [PATCH] perf lock: track only specified threads Hitoshi Mitake
2010-05-07  0:49                 ` Frederic Weisbecker
2010-05-08  8:02                   ` Hitoshi Mitake
2010-05-08  8:10                     ` [PATCH] perf lock: Drop "-a" option from set of default arguments to cmd_record() Hitoshi Mitake
2010-05-08 16:14                       ` Frederic Weisbecker
2010-05-09 14:53                         ` Hitoshi Mitake
2010-05-11  6:48                           ` Frederic Weisbecker
2010-05-12 10:23                             ` Hitoshi Mitake
2010-05-12 15:51                               ` Frederic Weisbecker
2010-05-15  8:54                                 ` Hitoshi Mitake
2010-05-10  7:19           ` [tip:perf/core] perf lock: Add "info" subcommand for dumping misc information tip-bot for Hitoshi Mitake
2010-04-24  2:05 ` Frederic Weisbecker [this message]
2010-04-24  2:05 ` [PATCH 3/9] perf: Generalize perf lock's sample event reordering to the session layer Frederic Weisbecker
2010-04-24  2:05 ` [PATCH 4/9] perf: Use generic sample reordering in perf sched Frederic Weisbecker
2010-04-24  2:05 ` [PATCH 5/9] perf: Use generic sample reordering in perf kmem Frederic Weisbecker
2010-04-24  2:05 ` [PATCH 6/9] perf: Use generic sample reordering in perf trace Frederic Weisbecker
2010-04-24  2:05 ` [PATCH 7/9] perf: Use generic sample reordering in perf timechart Frederic Weisbecker
2010-04-24  2:05 ` [PATCH 8/9] perf: Add a perf trace option to check samples ordering reliability Frederic Weisbecker
2010-04-24 16:13   ` Masami Hiramatsu
2010-04-25 18:08     ` Frederic Weisbecker
2010-04-24  2:05 ` [PATCH 9/9] perf: Some perf-kvm documentation edits Frederic Weisbecker
2010-04-24  2:27 ` [GIT PULL] perf tools updates Frederic Weisbecker
2010-04-27  9:15 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1272074742-3654-3-git-send-regression-fweisbec@gmail.com \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).