Re: [PATCH 3/3] generic sys_ipc wrapper

David Howells
2010-01-06T19:18:37Z

Christoph Hellwig <hch@lst.de> wrote:

> various architectures have different strategies for the SHMAT version 1 case
> which apparently never gets used - at least on i386 it seems superflous as
> the compat code on x86-64 and ia64 doesn't even bother to implement it.

The SHMAT version 1 case can be dropped for FRV and MN10300 - neither of them
support iBCS.

> frv goes even further and uses unsigned long for all parameters execept for
> "ptr" which is a pointer type everywhere. The change from int to unsigned
> long for "third" and back to "int" for the others on frv should be fine due
> to the in-register calling conventions for syscalls (we already had a
> similar issue with the generic sys_ptrace), but I'd prefer to have the arch
> maintainers looks over this in details.

That should be okay - the registers are all 32-bits, so int, long and pointers
are all the same size.

David