* [PATCH] gpiolib: make gpiochip_add() show a better error message
@ 2010-05-06 3:50 Ben Dooks
0 siblings, 0 replies; only message in thread
From: Ben Dooks @ 2010-05-06 3:50 UTC (permalink / raw)
To: linux-kernel; +Cc: dbrownell, akpm, gregkh, ext-jani.1.nikula, ak, Ben Dooks
The current message, 'not registered' is confusing as it implies it was
not registered with something, whereas printing 'failed to register' implies
it was the gpiochip_add() call that did not work correctly.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
---
drivers/gpio/gpiolib.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index eb0c3fe..384d993 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1106,7 +1106,7 @@ unlock:
fail:
/* failures here can mean systems won't boot... */
if (status)
- pr_err("gpiochip_add: gpios %d..%d (%s) not registered\n",
+ pr_err("gpiochip_add: gpios %d..%d (%s) failed to register\n",
chip->base, chip->base + chip->ngpio - 1,
chip->label ? : "generic");
return status;
--
1.6.3.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-05-06 3:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-06 3:50 [PATCH] gpiolib: make gpiochip_add() show a better error message Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox