[PATCH RESEND] mc13783-regulator: fix vaild voltage range checking for mc13783_fixed_regulator_set_voltage

[PATCH RESEND] mc13783-regulator: fix vaild voltage range checking for mc13783_fixed_regulator_set_voltage

[Axel Lin]

In the case of "min_uV == max_uV == mc13783_regulators[id].voltages[0]",
mc13783_fixed_regulator_set_voltage should return 0 instead of -EINVAL.

This patch also adds a missing ">" character for MODULE_AUTHOR, a trivial fix.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>
---
 drivers/regulator/mc13783-regulator.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/mc13783-regulator.c b/drivers/regulator/mc13783-regulator.c
index ad036dd..4597d50 100644
--- a/drivers/regulator/mc13783-regulator.c
+++ b/drivers/regulator/mc13783-regulator.c
@@ -440,8 +440,8 @@ static int mc13783_fixed_regulator_set_voltage(struct regulator_dev *rdev,
 	dev_dbg(rdev_get_dev(rdev), "%s id: %d min_uV: %d max_uV: %d\n",
 		__func__, id, min_uV, max_uV);
 
-	if (min_uV > mc13783_regulators[id].voltages[0] &&
-	    max_uV < mc13783_regulators[id].voltages[0])
+	if (min_uV >= mc13783_regulators[id].voltages[0] &&
+	    max_uV <= mc13783_regulators[id].voltages[0])
 		return 0;
 	else
 		return -EINVAL;
@@ -649,6 +649,6 @@ static void __exit mc13783_regulator_exit(void)
 module_exit(mc13783_regulator_exit);
 
 MODULE_LICENSE("GPL v2");
-MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix.de");
+MODULE_AUTHOR("Sascha Hauer <s.hauer@pengutronix.de>");
 MODULE_DESCRIPTION("Regulator Driver for Freescale MC13783 PMIC");
 MODULE_ALIAS("platform:mc13783-regulator");
-- 
1.5.4.3

Re: [PATCH RESEND] mc13783-regulator: fix vaild voltage range checking for mc13783_fixed_regulator_set_voltage

[Liam Girdwood]

On Thu, 2010-05-06 at 11:33 +0800, Axel Lin wrote:
> In the case of "min_uV == max_uV == mc13783_regulators[id].voltages[0]",
> mc13783_fixed_regulator_set_voltage should return 0 instead of -EINVAL.
> 
> This patch also adds a missing ">" character for MODULE_AUTHOR, a trivial fix.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> ---
>  drivers/regulator/mc13783-regulator.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 

Both patches look the same. Is there any reason for the resend ?

Thanks

Liam

Re: [PATCH RESEND] mc13783-regulator: fix vaild voltage range checking for mc13783_fixed_regulator_set_voltage

[Axel Lin]

hi Liam,

2010/5/6 Liam Girdwood <lrg@slimlogic.co.uk>:
> On Thu, 2010-05-06 at 11:33 +0800, Axel Lin wrote:
>> In the case of "min_uV == max_uV == mc13783_regulators[id].voltages[0]",
>> mc13783_fixed_regulator_set_voltage should return 0 instead of -EINVAL.
>>
>> This patch also adds a missing ">" character for MODULE_AUTHOR, a trivial fix.
>>
>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
>> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
>> ---
>>  drivers/regulator/mc13783-regulator.c |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>
>
> Both patches look the same. Is there any reason for the resend ?
I just found  my mail client make the first patch not able to be
cleanly applied by git-am.
The resend one fix it, and should be cleanly applied by git-am command.

Regards,
Axel

>
> Thanks
>
> Liam
>
>

Re: [PATCH RESEND] mc13783-regulator: fix vaild voltage range checking for mc13783_fixed_regulator_set_voltage

[Mark Brown]

On Thu, May 06, 2010 at 11:33:36AM +0800, Axel Lin wrote:
> In the case of "min_uV == max_uV == mc13783_regulators[id].voltages[0]",
> mc13783_fixed_regulator_set_voltage should return 0 instead of -EINVAL.
> 
> This patch also adds a missing ">" character for MODULE_AUTHOR, a trivial fix.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Better to send two patches for two separate fixes, especially where
there's no overlap in the code.

Re: [PATCH RESEND] mc13783-regulator: fix vaild voltage range checking for mc13783_fixed_regulator_set_voltage

[Liam Girdwood]

On Thu, 2010-05-06 at 11:33 +0800, Axel Lin wrote:
> In the case of "min_uV == max_uV == mc13783_regulators[id].voltages[0]",
> mc13783_fixed_regulator_set_voltage should return 0 instead of -EINVAL.
> 
> This patch also adds a missing ">" character for MODULE_AUTHOR, a trivial fix.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> ---
>  drivers/regulator/mc13783-regulator.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 

Applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk