From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>,
Steven Rostedt <rostedt@goodmis.org>
Subject: [PATCH 08/10] tracing: Factorize lock events in a lock class
Date: Sun, 9 May 2010 22:43:36 +0200 [thread overview]
Message-ID: <1273437818-8130-9-git-send-regression-fweisbec@gmail.com> (raw)
In-Reply-To: <1273437818-8130-1-git-send-regression-fweisbec@gmail.com>
lock_acquired, lock_contended and lock_release now share the
same prototype and format. Let's factorize them into a lock
event class.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Cc: Steven Rostedt <rostedt@goodmis.org>
---
include/trace/events/lock.h | 48 +++++++++++++-----------------------------
1 files changed, 15 insertions(+), 33 deletions(-)
diff --git a/include/trace/events/lock.h b/include/trace/events/lock.h
index fde4c38..2821b86 100644
--- a/include/trace/events/lock.h
+++ b/include/trace/events/lock.h
@@ -35,15 +35,15 @@ TRACE_EVENT(lock_acquire,
__get_str(name))
);
-TRACE_EVENT(lock_release,
+DECLARE_EVENT_CLASS(lock,
TP_PROTO(struct lockdep_map *lock, unsigned long ip),
TP_ARGS(lock, ip),
TP_STRUCT__entry(
- __string(name, lock->name)
- __field(void *, lockdep_addr)
+ __string( name, lock->name )
+ __field( void *, lockdep_addr )
),
TP_fast_assign(
@@ -51,48 +51,30 @@ TRACE_EVENT(lock_release,
__entry->lockdep_addr = lock;
),
- TP_printk("%p %s",
- __entry->lockdep_addr, __get_str(name))
+ TP_printk("%p %s", __entry->lockdep_addr, __get_str(name))
);
-#ifdef CONFIG_LOCK_STAT
-
-TRACE_EVENT(lock_contended,
+DEFINE_EVENT(lock, lock_release,
TP_PROTO(struct lockdep_map *lock, unsigned long ip),
- TP_ARGS(lock, ip),
-
- TP_STRUCT__entry(
- __string(name, lock->name)
- __field(void *, lockdep_addr)
- ),
+ TP_ARGS(lock, ip)
+);
- TP_fast_assign(
- __assign_str(name, lock->name);
- __entry->lockdep_addr = lock;
- ),
+#ifdef CONFIG_LOCK_STAT
- TP_printk("%p %s",
- __entry->lockdep_addr, __get_str(name))
-);
+DEFINE_EVENT(lock, lock_contended,
-TRACE_EVENT(lock_acquired,
TP_PROTO(struct lockdep_map *lock, unsigned long ip),
- TP_ARGS(lock, ip),
+ TP_ARGS(lock, ip)
+);
- TP_STRUCT__entry(
- __string(name, lock->name)
- __field(void *, lockdep_addr)
- ),
+DEFINE_EVENT(lock, lock_acquired,
- TP_fast_assign(
- __assign_str(name, lock->name);
- __entry->lockdep_addr = lock;
- ),
- TP_printk("%p %s", __entry->lockdep_addr,
- __get_str(name))
+ TP_PROTO(struct lockdep_map *lock, unsigned long ip),
+
+ TP_ARGS(lock, ip)
);
#endif
--
1.6.2.3
next prev parent reply other threads:[~2010-05-09 20:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-09 20:43 [GIT PULL] perf updates Frederic Weisbecker
2010-05-09 20:43 ` [PATCH 01/10] perf lock: Add "info" subcommand for dumping misc information Frederic Weisbecker
2010-05-09 20:43 ` [PATCH 02/10] perf: Cleanup perf lock broken states Frederic Weisbecker
2010-05-09 20:43 ` [PATCH 03/10] perf: Humanize lock flags in perf lock Frederic Weisbecker
2010-05-09 20:43 ` [PATCH 04/10] perf: Fix perf lock bad rate Frederic Weisbecker
2010-05-09 20:43 ` [PATCH 05/10] perf lock: Always check min AND max wait time Frederic Weisbecker
2010-05-09 20:43 ` [PATCH 06/10] tracing: Drop lock_acquired waittime field Frederic Weisbecker
2010-05-09 20:43 ` [PATCH 07/10] tracing: Drop the nested field from lock_release event Frederic Weisbecker
2010-05-09 20:43 ` Frederic Weisbecker [this message]
2010-05-09 20:43 ` [PATCH 09/10] perf/live-mode: Handle payload-less events Frederic Weisbecker
2010-05-09 20:43 ` [PATCH 10/10] perf lock: Drop "-a" option from cmd_record() default arguments set Frederic Weisbecker
2010-05-10 5:10 ` [GIT PULL] perf updates Frederic Weisbecker
2010-05-10 6:46 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273437818-8130-9-git-send-regression-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mitake@dcl.info.waseda.ac.jp \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).