From: Daniel Mack <daniel@caiaq.de>
To: linux-kernel@vger.kernel.org
Cc: Daniel Mack <daniel@caiaq.de>,
Anton Vorontsov <avorontsov@ru.mvista.com>,
Matt Reimer <mreimer@vpop.net>,
Evgeniy Polyakov <zbr@ioremap.net>, Tejun Heo <tj@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Len Brown <len.brown@intel.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 3/3] power/ds2760_battery: use factor of 20 for rated_capacity
Date: Tue, 11 May 2010 18:38:46 +0200 [thread overview]
Message-ID: <1273595926-26249-3-git-send-email-daniel@caiaq.de> (raw)
In-Reply-To: <1273595926-26249-1-git-send-email-daniel@caiaq.de>
In the ds2760 driver, the currently used factor of 10 to store the rated
battery capacity internally is not sufficient for batteries > 2.55 Ah,
as the 8-bit register will overflow for bigger values.
Change the factor to 20 to broaden that range. Note that due to
RATED_CAPACITY_FACTOR, the external interface won't change, neither for
the writeable sysfs entires nor for the kernel rated_capacity module
parameter.
Signed-off-by: Daniel Mack <daniel@caiaq.de>
Cc: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Matt Reimer <mreimer@vpop.net>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Tejun Heo <tj@kernel.org>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Len Brown <len.brown@intel.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/power/ds2760_battery.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/power/ds2760_battery.c b/drivers/power/ds2760_battery.c
index b82bf92..7b3043f 100644
--- a/drivers/power/ds2760_battery.c
+++ b/drivers/power/ds2760_battery.c
@@ -78,7 +78,7 @@ MODULE_PARM_DESC(current_accum, "current accumulator value");
/* Some batteries have their rated capacity stored a N * 10 mAh, while
* others use an index into this table. */
-#define RATED_CAPACITY_FACTOR 10
+#define RATED_CAPACITY_FACTOR 20
static int rated_capacities[] = {
0,
920, /* Samsung */
--
1.7.1
next prev parent reply other threads:[~2010-05-11 16:39 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 16:38 [PATCH 1/3] pda_power: add support for writeable properties Daniel Mack
2010-05-11 16:38 ` [PATCH 2/3] power/ds2760_battery: make charge_now and charge_full writeable Daniel Mack
2010-05-11 16:44 ` Daniel Mack
2010-05-11 17:20 ` Anton Vorontsov
2010-05-11 17:28 ` Daniel Mack
2010-05-11 18:05 ` Anton Vorontsov
2010-05-18 18:24 ` Daniel Mack
2010-05-11 16:38 ` Daniel Mack [this message]
2010-05-11 17:19 ` [PATCH 3/3] power/ds2760_battery: use factor of 20 for rated_capacity Anton Vorontsov
2010-05-11 17:25 ` Daniel Mack
2010-05-11 17:47 ` Anton Vorontsov
2010-05-11 17:47 ` [PATCH 1/3] pda_power: add support for writeable properties Anton Vorontsov
2010-05-11 17:58 ` Daniel Mack
2010-05-11 18:23 ` Anton Vorontsov
2010-05-11 22:28 ` Daniel Mack
2010-05-12 18:15 ` [PATCH] Introduce {sysfs,device}_create_file_mode Anton Vorontsov
2010-05-12 18:18 ` Daniel Mack
2010-05-12 18:38 ` Greg KH
2010-05-12 19:08 ` Anton Vorontsov
2010-05-12 19:12 ` Kay Sievers
2010-05-12 19:19 ` Greg KH
2010-05-12 19:39 ` Anton Vorontsov
2010-05-12 19:30 ` Anton Vorontsov
2010-05-13 9:33 ` Daniel Mack
2010-05-17 19:40 ` [PATCH] power_supply: Use attribute groups Anton Vorontsov
2010-05-18 17:35 ` Daniel Mack
2010-05-18 19:49 ` [PATCH 1/3] " Daniel Mack
2010-05-18 19:49 ` [PATCH 2/3] pda_power: add support for writeable properties Daniel Mack
2010-05-18 19:56 ` Greg KH
2010-05-18 20:30 ` [PATCH] power/ds2760_battery: document ABI change Daniel Mack
2010-05-19 8:34 ` Anton Vorontsov
2010-05-18 19:49 ` [PATCH 3/3] power/ds2760_battery: make charge_now and charge_full writeable Daniel Mack
2010-05-11 18:32 ` [PATCH 1/3] pda_power: add support for writeable properties Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273595926-26249-3-git-send-email-daniel@caiaq.de \
--to=daniel@caiaq.de \
--cc=avorontsov@ru.mvista.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dwmw2@infradead.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mreimer@vpop.net \
--cc=tj@kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).