From: Bastien Nocera <hadess@hadess.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] Disable i8042 checks on Intel Apple Macs
Date: Wed, 12 May 2010 01:11:23 +0100 [thread overview]
Message-ID: <1273623083.2314.4.camel@localhost.localdomain> (raw)
As those computers never had any i8042 controllers, and the
current lookup code could potentially lock up/hang/wait for
timeout for long periods of time.
Fixes intermittent hangs on boot on a MacbookAir1,1
Signed-off-by: Bastien Nocera <hadess@hadess.net>
---
drivers/input/serio/i8042-x86ia64io.h | 18 ++++++++++++++++++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
index ead0494..e859902 100644
--- a/drivers/input/serio/i8042-x86ia64io.h
+++ b/drivers/input/serio/i8042-x86ia64io.h
@@ -479,6 +479,22 @@ static const struct dmi_system_id __initconst i8042_dmi_reset_table[] = {
{ }
};
+/* Intel Apple Macs never have an i8042 controller,
+ * so we shouldn't even try to probe for it */
+static const struct dmi_system_id __initconst i8042_dmi_no_probe_table[] = {
+ {
+ .matches = {
+ DMI_MATCH(DMI_BIOS_VENDOR, "Apple Computer, Inc.")
+ },
+ },
+ {
+ .matches = {
+ DMI_MATCH(DMI_BIOS_VENDOR, "Apple Inc.")
+ },
+ },
+ {}
+};
+
#ifdef CONFIG_PNP
static const struct dmi_system_id __initconst i8042_dmi_nopnp_table[] = {
{
@@ -833,6 +849,8 @@ static int __init i8042_platform_init(void)
* if (!request_region(I8042_DATA_REG, 16, "i8042"))
* return -EBUSY;
*/
+ if (dmi_check_system(i8042_dmi_no_probe_table))
+ return -ENODEV;
i8042_kbd_irq = I8042_MAP_IRQ(1);
i8042_aux_irq = I8042_MAP_IRQ(12);
--
1.7.0.1
next reply other threads:[~2010-05-12 0:11 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 0:11 Bastien Nocera [this message]
2010-05-12 10:51 ` [PATCH] Disable i8042 checks on Intel Apple Macs Felipe Contreras
2010-05-12 11:00 ` Felipe Contreras
2010-05-12 17:51 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2010-05-04 17:36 Bastien Nocera
2010-05-04 17:55 ` Pekka Enberg
2010-05-04 18:02 ` Dmitry Torokhov
2010-05-05 9:18 ` Bastien Nocera
2010-05-05 21:27 ` Kyle McMartin
2010-01-20 18:23 Bastien Nocera
2010-01-20 19:14 ` Justin P. Mattock
2010-01-20 19:37 ` Bastien Nocera
2010-01-20 19:54 ` Justin P. Mattock
2010-01-21 0:41 ` Robert Hancock
2010-01-21 1:31 ` Bastien Nocera
2010-01-21 2:19 ` Robert Hancock
2010-01-21 18:55 ` Dmitry Torokhov
2010-01-21 21:39 ` Robert Hancock
2010-01-21 21:42 ` Bastien Nocera
2010-01-21 21:49 ` Justin P. Mattock
2010-01-22 0:29 ` Robert Hancock
2010-01-22 1:20 ` Justin P. Mattock
2010-01-22 2:09 ` Bastien Nocera
2010-01-22 2:30 ` Robert Hancock
2010-01-22 2:53 ` Bastien Nocera
2010-01-22 2:31 ` Justin P. Mattock
2010-01-21 22:17 ` Dmitry Torokhov
2010-01-22 0:26 ` Robert Hancock
2010-01-22 17:46 ` H. Peter Anvin
2010-01-22 18:15 ` Bastien Nocera
2010-01-22 22:33 ` Robert Hancock
2010-01-22 22:49 ` H. Peter Anvin
2010-01-25 16:34 ` Vojtech Pavlik
2010-01-25 21:32 ` H. Peter Anvin
2010-01-25 22:15 ` Dmitry Torokhov
2010-01-25 22:18 ` H. Peter Anvin
2010-01-25 22:30 ` Dmitry Torokhov
2010-01-25 23:05 ` H. Peter Anvin
2010-01-25 23:28 ` Dmitry Torokhov
2010-01-25 23:31 ` H. Peter Anvin
2010-05-04 17:06 ` Bastien Nocera
2010-05-04 17:23 ` Dmitry Torokhov
2010-05-04 17:37 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273623083.2314.4.camel@localhost.localdomain \
--to=hadess@hadess.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).