* [PATCH] fsnotify: initialize mask in fsnotify_perm
@ 2010-05-12 15:49 Eric Paris
0 siblings, 0 replies; only message in thread
From: Eric Paris @ 2010-05-12 15:49 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, Eric Paris
akpm got a warning the fsnotify_mask could be used uninitialized in
fsnotify_perm(). It's not actually possible but his compiler complained
about it. This patch just initializes it to 0 to shut up the compiler.
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Eric Paris <eparis@redhat.com>
---
include/linux/fsnotify.h | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/linux/fsnotify.h b/include/linux/fsnotify.h
index 64efda9..59d0df4 100644
--- a/include/linux/fsnotify.h
+++ b/include/linux/fsnotify.h
@@ -39,16 +39,18 @@ static inline int fsnotify_perm(struct file *file, int mask)
{
struct path *path = &file->f_path;
struct inode *inode = path->dentry->d_inode;
- __u32 fsnotify_mask;
+ __u32 fsnotify_mask = 0;
if (file->f_mode & FMODE_NONOTIFY)
return 0;
if (!(mask & (MAY_READ | MAY_OPEN)))
return 0;
- if (mask & MAY_READ)
- fsnotify_mask = FS_ACCESS_PERM;
if (mask & MAY_OPEN)
fsnotify_mask = FS_OPEN_PERM;
+ else if (mask & MAY_READ)
+ fsnotify_mask = FS_ACCESS_PERM;
+ else
+ BUG();
return fsnotify(inode, fsnotify_mask, path, FSNOTIFY_EVENT_PATH, NULL, 0);
}
--
1.6.5.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-05-12 15:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-12 15:49 [PATCH] fsnotify: initialize mask in fsnotify_perm Eric Paris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).