linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: linux-mtd@lists.infradead.org,
	Bernd Schmidt <bernd.schmidt@analog.com>,
	David Howells <dhowells@redhat.com>,
	Sudhakar Rajashekhara <sudhakar.raj@ti.com>,
	Nicolas Pitre <nico@fluxnic.net>,
	linux-kernel@vger.kernel.org,
	David Brownell <david-b@pacbell.net>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] mtdpart: memory accessor interface for MTD layer
Date: Fri, 14 May 2010 00:50:29 +0100	[thread overview]
Message-ID: <1273794629.9999.412.camel@macbook.infradead.org> (raw)
In-Reply-To: <1268772081-6534-1-git-send-email-khilman@deeprootsystems.com>

On Tue, 2010-03-16 at 13:41 -0700, Kevin Hilman wrote:
> From: Sudhakar Rajashekhara <sudhakar....@ti.com>
> 
> This patch implements memory accessor interface in the MTD
> layer which enables the kernel to access flash data.
> 
> This patch adds two new members to the mtd_partition structure,
> a function handler which will be called during setup of the
> partition and an argument to be passed to this setup function.

Ick.

I don't mind providing the mtd_macc_{read,write} helper functions,
although they should work on generic MTD devices not just on partitions.
But do we really have to do the callout to arbitrary functions from
_within_ the core MTD code... why can't we do that in the board driver?

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation


  parent reply	other threads:[~2010-05-13 23:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-16 20:41 [PATCH 1/2] mtdpart: memory accessor interface for MTD layer Kevin Hilman
2010-04-08  8:10 ` Artem Bityutskiy
2010-05-13 23:50 ` David Woodhouse [this message]
     [not found] <012f01cb1dc3$09584880$1c08d980$@raj@ti.com>
2010-07-07 11:08 ` David Brownell
2010-08-04 10:12   ` David Woodhouse
2010-08-04 10:31     ` David Brownell
2010-08-04 11:08       ` David Woodhouse
2010-08-04 11:27         ` David Brownell
     [not found]         ` <000401cb3533$5c982470$15c86d50$@raj@ti.com>
2010-08-08 12:23           ` David Woodhouse
     [not found] <027001cb1eaf$a7dc64e0$f7952ea0$@raj@ti.com>
2010-07-08 16:00 ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273794629.9999.412.camel@macbook.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=bernd.schmidt@analog.com \
    --cc=david-b@pacbell.net \
    --cc=dbrownell@users.sourceforge.net \
    --cc=dhowells@redhat.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=nico@fluxnic.net \
    --cc=sudhakar.raj@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).