From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, mingo@elte.hu, paulus@samba.org,
acme@redhat.com
Subject: Re: [PATCH RFC] perf: fix find_swevent_head() RCU lockdep splat
Date: Fri, 14 May 2010 09:44:24 +0200 [thread overview]
Message-ID: <1273823064.5605.3599.camel@twins> (raw)
In-Reply-To: <20100513190325.GB5377@nowhere>
On Thu, 2010-05-13 at 21:03 +0200, Frederic Weisbecker wrote:
> hlist = rcu_dereference_check(ctx->swevent_hlist,
> rcu_read_lock_held() ||
> raw_spin_lock_is_held(&ctx->lock));
raw_spin_lock_is_held() is wrong, that should read:
lockdep_is_held(&ctx->lock).
raw_spin_lock_is_held() only checks if the lock is locked,
lockdep_is_held() ensures we are the one holding it.
next prev parent reply other threads:[~2010-05-14 7:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 18:25 [PATCH RFC] perf: fix find_swevent_head() RCU lockdep splat Paul E. McKenney
2010-05-13 19:03 ` Frederic Weisbecker
2010-05-13 19:46 ` Paul E. McKenney
2010-05-13 20:26 ` Frederic Weisbecker
2010-05-13 20:48 ` Frederic Weisbecker
2010-05-13 20:59 ` Frederic Weisbecker
2010-05-13 23:43 ` Paul E. McKenney
2010-05-20 7:01 ` Frederic Weisbecker
2010-05-14 7:47 ` Peter Zijlstra
2010-05-20 7:04 ` Frederic Weisbecker
2010-05-14 7:44 ` Peter Zijlstra [this message]
2010-05-20 7:04 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273823064.5605.3599.camel@twins \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox