public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: commit e9e9250b: sync wakeup bustage when waker is an RT task
Date: Sat, 15 May 2010 13:57:08 +0200	[thread overview]
Message-ID: <1273924628.10630.24.camel@marge.simson.net> (raw)

Hi Peter,

This commit excluded RT tasks from rq->load, was that intentional?  The
comment in struct rq states that load reflects *all* tasks, but since
this commit, that's no longer true.

Looking at lmbench lat_udp in a PREEMPT_RT kernel, I noticed that
wake_affine() is failing for sync wakeups when it should not.  It's
doing so because the waker in this case is an RT kernel thread
(sirq-net-rx) - we subtract the sync waker's weight, when it was never
added in the first place, resulting in this_load going gaga.  End result
is quite high latency numbers due to tasks jabbering cross-cache.

If the exclusion was intentional, I suppose I can do a waker class check
in wake_affine() to fix it.

	-Mike



             reply	other threads:[~2010-05-15 11:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-15 11:57 Mike Galbraith [this message]
2010-05-15 12:04 ` commit e9e9250b: sync wakeup bustage when waker is an RT task Peter Zijlstra
2010-05-15 17:07   ` Mike Galbraith
2010-05-15 17:32     ` Mike Galbraith
2010-05-16  7:21     ` Mike Galbraith
2010-05-17  4:38       ` Mike Galbraith
2010-05-17  8:49         ` Peter Zijlstra
2010-05-17  8:52           ` Peter Zijlstra
2010-05-17  9:04           ` Mike Galbraith
2010-05-31 11:56       ` Peter Zijlstra
2010-05-31 13:56         ` Mike Galbraith
2010-05-31 14:28           ` Peter Zijlstra
2010-05-31 18:03             ` Mike Galbraith
2010-06-01  6:40               ` Mike Galbraith
2010-06-01  9:12             ` [tip:sched/urgent] sched: Fix wake_affine() vs RT tasks tip-bot for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273924628.10630.24.camel@marge.simson.net \
    --to=efault@gmx.de \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox