From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org, mingo@elte.hu, paulus@samba.org,
davem@davemloft.net, acme@infradead.org,
perfmon2-devel@lists.sf.net, eranian@gmail.com
Subject: Re: [PATCH] perf_events: fix errors path in perf_output_begin()
Date: Mon, 17 May 2010 14:09:35 +0200 [thread overview]
Message-ID: <1274098175.5605.4661.camel@twins> (raw)
In-Reply-To: <AANLkTilJH8RnWjBIY7vrOnXi7w1_z8j9_abD-8tuwL-u@mail.gmail.com>
On Mon, 2010-05-17 at 14:04 +0200, Stephane Eranian wrote:
>
> > So you want to preserve this state for when you munmap() and mmap()
> > again? The only user of data->lost is writing the PERF_RECORD_LOST
> > event, which only ever happens when you have pages, so counting it when
> > there's no pages seems futile.
>
> You're right. But couldn't you report lost samples in the buffer header as well?
I guess you could, but what's the point? If you ask for sampling but
don't provide a buffer you don't get anything -- how's that a surprise?
next prev parent reply other threads:[~2010-05-17 12:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 10:46 [PATCH] perf_events: fix errors path in perf_output_begin() Stephane Eranian
2010-05-17 11:04 ` John Kacur
2010-05-17 11:57 ` Stephane Eranian
2010-05-17 11:46 ` Frederic Weisbecker
2010-05-17 11:56 ` Stephane Eranian
2010-05-17 12:03 ` Peter Zijlstra
2010-05-17 12:04 ` Stephane Eranian
2010-05-17 12:09 ` Peter Zijlstra [this message]
2010-05-17 12:23 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274098175.5605.4661.camel@twins \
--to=peterz@infradead.org \
--cc=acme@infradead.org \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox