linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Herbert Xu <herbert@gondor.hengli.com.au>, manfred@colorfullife.com
Cc: David Miller <davem@davemloft.net>,
	penberg@cs.helsinki.fi, mpm@selenic.com, ken@codelabs.ch,
	geert@linux-m68k.org, michael-dev@fami-braun.de,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	anemo@mba.ocn.ne.jp
Subject: [PATCH 1/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALLOC_MINALIGN to <linux/slab_def.h>
Date: Wed, 19 May 2010 12:01:42 +0100	[thread overview]
Message-ID: <1274266902.6930.9834.camel@macbook.infradead.org> (raw)
In-Reply-To: <1274266725.6930.9823.camel@macbook.infradead.org>

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
---
 include/linux/slab_def.h |   24 ++++++++++++++++++++++++
 mm/slab.c                |   24 ------------------------
 2 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/include/linux/slab_def.h b/include/linux/slab_def.h
index ca6b2b3..1812dac 100644
--- a/include/linux/slab_def.h
+++ b/include/linux/slab_def.h
@@ -16,6 +16,30 @@
 #include <linux/compiler.h>
 #include <linux/kmemtrace.h>
 
+#ifndef ARCH_KMALLOC_MINALIGN
+/*
+ * Enforce a minimum alignment for the kmalloc caches.
+ * Usually, the kmalloc caches are cache_line_size() aligned, except when
+ * DEBUG and FORCED_DEBUG are enabled, then they are BYTES_PER_WORD aligned.
+ * Some archs want to perform DMA into kmalloc caches and need a guaranteed
+ * alignment larger than the alignment of a 64-bit integer.
+ * ARCH_KMALLOC_MINALIGN allows that.
+ * Note that increasing this value may disable some debug features.
+ */
+#define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long)
+#endif
+
+#ifndef ARCH_SLAB_MINALIGN
+/*
+ * Enforce a minimum alignment for all caches.
+ * Intended for archs that get misalignment faults even for BYTES_PER_WORD
+ * aligned buffers. Includes ARCH_KMALLOC_MINALIGN.
+ * If possible: Do not enable this flag for CONFIG_DEBUG_SLAB, it disables
+ * some debug features.
+ */
+#define ARCH_SLAB_MINALIGN 0
+#endif
+
 /*
  * struct kmem_cache
  *
diff --git a/mm/slab.c b/mm/slab.c
index bac0f4f..7401ddc 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -144,30 +144,6 @@
 #define	BYTES_PER_WORD		sizeof(void *)
 #define	REDZONE_ALIGN		max(BYTES_PER_WORD, __alignof__(unsigned long long))
 
-#ifndef ARCH_KMALLOC_MINALIGN
-/*
- * Enforce a minimum alignment for the kmalloc caches.
- * Usually, the kmalloc caches are cache_line_size() aligned, except when
- * DEBUG and FORCED_DEBUG are enabled, then they are BYTES_PER_WORD aligned.
- * Some archs want to perform DMA into kmalloc caches and need a guaranteed
- * alignment larger than the alignment of a 64-bit integer.
- * ARCH_KMALLOC_MINALIGN allows that.
- * Note that increasing this value may disable some debug features.
- */
-#define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long)
-#endif
-
-#ifndef ARCH_SLAB_MINALIGN
-/*
- * Enforce a minimum alignment for all caches.
- * Intended for archs that get misalignment faults even for BYTES_PER_WORD
- * aligned buffers. Includes ARCH_KMALLOC_MINALIGN.
- * If possible: Do not enable this flag for CONFIG_DEBUG_SLAB, it disables
- * some debug features.
- */
-#define ARCH_SLAB_MINALIGN 0
-#endif
-
 #ifndef ARCH_KMALLOC_FLAGS
 #define ARCH_KMALLOC_FLAGS SLAB_HWCACHE_ALIGN
 #endif
-- 
1.6.6.1




  reply	other threads:[~2010-05-19 11:02 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-15 13:39 [BUG] SLOB breaks Crypto michael-dev
2010-03-18 16:30 ` Pekka Enberg
2010-03-18 21:24   ` michael-dev
2010-03-19  0:33     ` Herbert Xu
2010-05-14 14:50       ` Adrian-Ken Rueegsegger
2010-05-17 16:17       ` Geert Uytterhoeven
2010-05-17 21:50         ` Adrian-Ken Rueegsegger
2010-05-17 22:37           ` Matt Mackall
2010-05-18  8:17             ` Adrian-Ken Rueegsegger
2010-05-18 10:27               ` Herbert Xu
2010-05-18 14:02                 ` Pekka Enberg
2010-05-18 19:06                 ` Matt Mackall
2010-05-18 19:25                 ` David Miller
2010-05-18 19:33                   ` Matt Mackall
2010-05-18 20:59                     ` David Miller
2010-05-18 21:15                       ` Pekka Enberg
2010-05-18 21:20                         ` David Miller
2010-05-18 22:35                           ` Paul Mundt
2010-05-18 22:37                             ` Paul Mundt
2010-05-19 15:19                               ` Christoph Lameter
2010-05-19 19:56                                 ` David Miller
2010-05-18 22:40                             ` David Miller
2010-05-18 23:10                               ` Paul Mundt
2010-05-18 23:16                               ` Matt Mackall
2010-05-19  5:53                               ` Pekka Enberg
2010-05-18 23:20                           ` David Woodhouse
2010-05-19  1:05                             ` Herbert Xu
2010-05-19  7:14                               ` David Woodhouse
2010-05-19  7:45                                 ` Herbert Xu
2010-05-19 11:32                                 ` Geert Uytterhoeven
2010-05-19 11:40                                   ` David Woodhouse
2010-05-19 11:50                                     ` Geert Uytterhoeven
2010-05-19 14:11                                       ` Matt Mackall
2010-05-19 19:33                                         ` David Miller
2010-05-20  3:38                                           ` FUJITA Tomonori
2010-05-20  3:46                                             ` David Miller
2010-05-19 12:02                                     ` FUJITA Tomonori
2010-05-19 12:19                                       ` David Woodhouse
2010-05-19 12:26                                         ` FUJITA Tomonori
2010-05-19 12:48                                           ` David Woodhouse
2010-05-19 10:58                               ` David Woodhouse
2010-05-19 11:01                                 ` David Woodhouse [this message]
2010-05-19 13:30                                   ` [PATCH 1/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALLOC_MINALIGN to <linux/slab_def.h> Johannes Stezenbach
2010-05-19 18:03                                     ` Manfred Spraul
2010-05-19 18:10                                       ` David Woodhouse
2010-05-20 16:49                                         ` Manfred Spraul
2010-05-19 19:11                                   ` Pekka Enberg
2010-05-19 19:19                                     ` Christoph Lameter
2010-05-19 19:23                                       ` Pekka Enberg
2010-05-19 19:45                                         ` Christoph Lameter
2010-05-19 19:28                                       ` David Woodhouse
2010-05-19 11:01                                 ` [PATCH 2/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALLOC_MINALIGN to <linux/slob_def.h> David Woodhouse
2010-05-19 11:02                                 ` [PATCH 3/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALLOC_MINALIGN to <linux/slub_def.h> David Woodhouse
2010-05-19 11:02                                 ` [PATCH 4/4] crypto: Use ARCH_KMALLOC_MINALIGN for CRYPTO_MINALIGN now that it's exposed David Woodhouse
2010-05-19 11:08                                 ` [BUG] SLOB breaks Crypto Pekka Enberg
2010-05-19 11:16                                   ` David Woodhouse
2010-05-19 11:46                                     ` Herbert Xu
2010-05-19 12:54                                       ` Pekka Enberg
2010-05-19 12:59                                         ` Herbert Xu
2010-05-19 19:51                                           ` David Miller
2010-05-19 19:42                                     ` David Miller
2010-05-19 13:49                                 ` [PATCH 5/4] Provide __dma_aligned macro David Woodhouse
2010-05-19 14:50                                   ` FUJITA Tomonori
2010-05-19  4:09                           ` [BUG] SLOB breaks Crypto Herbert Xu
2010-05-19  5:44                           ` Pekka Enberg
2010-05-18 19:32                 ` Adrian-Ken Rueegsegger
2010-05-18 22:39                   ` Herbert Xu
2010-05-19  1:51                   ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274266902.6930.9834.camel@macbook.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=herbert@gondor.hengli.com.au \
    --cc=ken@codelabs.ch \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=michael-dev@fami-braun.de \
    --cc=mpm@selenic.com \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).