From: Peter Zijlstra <peterz@infradead.org>
To: Nikhil Rao <ncrao@google.com>
Cc: Ingo Molnar <mingo@elte.hu>, Mike Galbraith <efault@gmx.de>,
Venkatesh Pallipadi <venki@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: fix updating sd->balance_interval in idle_balance()
Date: Thu, 20 May 2010 09:16:49 +0200 [thread overview]
Message-ID: <1274339809.5605.13119.camel@twins> (raw)
In-Reply-To: <1274312730-3041-1-git-send-email-ncrao@google.com>
On Wed, 2010-05-19 at 16:45 -0700, Nikhil Rao wrote:
> sd->balance_interval is updated incorrectly when SD_BALANCE_NEWIDLE is not set
> in sd->flags. This patch updates sd->balance_interval only when we balance the
> domain.
I really need more than that.
Why is it wrong, what are the (measurable) effects of changing it and
how did it come to be this way.
I could of course go and try to reverse engineer your patch, but it
would be awesome if I didn't have to.
prev parent reply other threads:[~2010-05-20 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 23:45 [PATCH] sched: fix updating sd->balance_interval in idle_balance() Nikhil Rao
2010-05-20 7:16 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274339809.5605.13119.camel@twins \
--to=peterz@infradead.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ncrao@google.com \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox