From: Peter Zijlstra <peterz@infradead.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: David Miller <davem@davemloft.net>,
suresh.b.siddha@intel.com, mingo@elte.hu, tglx@linutronix.de,
arjan@linux.jf.intel.com, venki@google.com,
svaidy@linux.vnet.ibm.com, ego@in.ibm.com,
linux-kernel@vger.kernel.org, linux@dominikbrodowski.net,
ncunningham@crca.org.au
Subject: Re: [patch 3/7] softirq: avoid softirq_work_list for SCHED_SOFTIRQ when sent remotely
Date: Thu, 20 May 2010 10:29:18 +0200 [thread overview]
Message-ID: <1274344158.5605.13394.camel@twins> (raw)
In-Reply-To: <20100520082309.GH25951@kernel.dk>
On Thu, 2010-05-20 at 10:23 +0200, Jens Axboe wrote:
> On Thu, May 20 2010, David Miller wrote:
> > From: Peter Zijlstra <peterz@infradead.org>
> > Date: Thu, 20 May 2010 10:12:39 +0200
> >
> > > Most odd all that, Dave, Jens, what happened to all that remote_softirq
> > > stuff?
> >
> > Nobody ended up using this remote softirq infrastructure, it can be
> > completely deleted.
>
> What parts of it? There has been reworks of parts of the code since I
> added it, the block layer only uses __smp_call_function_single() to
> trigger remote softirqs.
Right, so __smp_call_function_single() is the normal remote ipi stuff
from kernel/smp.c, send_remote_softirq() is the pile of code in
kernel/softirq.c that uses that to tickle remote softirqs.
The 'problem' seems to be that the remote softirq code (not the ipi
bits) doesn't have any users and is quite complex and apparently
incomplete.
Suresh, would it make sense to do as Jens does and simply use
__smp_call_function_single() or do you think it still makes sense to
have a small wrapper and maybe share that with Jens?
next prev parent reply other threads:[~2010-05-20 8:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 18:27 [patch 0/7] sched: change nohz idle load balancing logic to push model Suresh Siddha
2010-05-17 18:27 ` [patch 1/7] softirq: Add a no local fallback option to send_remote_softirq Suresh Siddha
2010-05-17 18:27 ` [patch 2/7] softirq: add init_remote_softirq_csd() Suresh Siddha
2010-05-17 18:27 ` [patch 3/7] softirq: avoid softirq_work_list for SCHED_SOFTIRQ when sent remotely Suresh Siddha
2010-05-20 8:12 ` Peter Zijlstra
2010-05-20 8:14 ` David Miller
2010-05-20 8:23 ` Jens Axboe
2010-05-20 8:29 ` Peter Zijlstra [this message]
2010-05-20 9:18 ` David Miller
2010-05-17 18:27 ` [patch 4/7] sched: Change nohz ilb logic from pull to push model Suresh Siddha
2010-06-01 23:47 ` Vaidyanathan Srinivasan
2010-06-02 22:27 ` Suresh Siddha
2010-05-17 18:27 ` [patch 5/7] sched: Change select_nohz_load_balancer to return void Suresh Siddha
2010-05-17 18:27 ` [patch 6/7] sched: change nohz.load_balancer to be nr_cpu_ids based Suresh Siddha
2010-05-20 9:49 ` Peter Zijlstra
2010-05-17 18:27 ` [patch 7/7] timers: use nearest busy cpu for migrating timers from an idle cpu Suresh Siddha
2010-06-01 23:37 ` Vaidyanathan Srinivasan
2010-06-02 22:02 ` Suresh Siddha
2010-05-17 22:39 ` [patch 0/7] sched: change nohz idle load balancing logic to push model Nigel Cunningham
2010-05-19 9:19 ` Dominik Brodowski
2010-05-20 10:50 ` Peter Zijlstra
2010-05-22 0:09 ` Suresh Siddha
2010-05-31 9:17 ` Peter Zijlstra
2010-06-09 10:13 ` [tip:sched/core] sched: Change " tip-bot for Venkatesh Pallipadi
2010-05-20 11:07 ` [patch 0/7] sched: change " Nigel Cunningham
2010-05-20 11:17 ` Dominik Brodowski
2010-05-20 11:35 ` Nigel Cunningham
2010-05-20 12:13 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274344158.5605.13394.camel@twins \
--to=peterz@infradead.org \
--cc=arjan@linux.jf.intel.com \
--cc=davem@davemloft.net \
--cc=ego@in.ibm.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=mingo@elte.hu \
--cc=ncunningham@crca.org.au \
--cc=suresh.b.siddha@intel.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).