Re: [PATCH 01/10] perf, trace: Remove IRQ-disable from perf/tracepoint interaction

Frank Ch. Eigler
2010-05-21T18:07:43Z

Hi -

On Fri, May 21, 2010 at 01:53:00PM -0400, Steven Rostedt wrote:
> [...]
> > > - struct pt_regs *__regs = &get_cpu_var(perf_trace_regs); \
> > > - [...]
> > > + struct pt_regs __regs; \
> > > [...]
> >
> > To what extent are you worried about something the size of struct
> > pt_regs being auto/stack allocated?
>
> Isn't pt_regs already allocated on the stack when interrupted?

Maybe, but here we're about to ask for another multi-hundred-byte one.
Does your stack-frame-size ftrace widget gripe about this change?

- FChE