Re: [PATCH 01/10] perf, trace: Remove IRQ-disable from perf/tracepoint interaction

Paul Mackerras
2010-05-23T12:48:45Z

On Fri, May 21, 2010 at 11:02:02AM +0200, Peter Zijlstra wrote:

> entry = (struct trace_entry *)raw_data;
> - tracing_generic_entry_update(entry, *irq_flags, pc);
> + tracing_generic_entry_update(entry, regs->flags, pc);
> entry->type = type;

This is breaking on powerpc -- we don't have a "flags" element in
struct pt_regs. What is it trying to do? Get the interrupt enable
state, as local_irq_save(flags) would provide?

Paul.