From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934155Ab0EZJpQ (ORCPT ); Wed, 26 May 2010 05:45:16 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:47437 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934086Ab0EZJpM convert rfc822-to-8bit (ORCPT ); Wed, 26 May 2010 05:45:12 -0400 Subject: Re: [PATCH 0/8] Suspend block api (version 8) From: Peter Zijlstra To: Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= Cc: "Rafael J. Wysocki" , Kevin Hilman , felipe.balbi@nokia.com, Linux PM , LKML , Linux OMAP Mailing List , Tony Lindgren , Paul Walmsley In-Reply-To: References: <1274482015-30899-1-git-send-email-arve@android.com> <201005242049.18920.rjw@sisk.pl> <87wrusvrqe.fsf@deeprootsystems.com> <201005250138.16293.rjw@sisk.pl> <1274863655.5882.4875.camel@twins> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Wed, 26 May 2010 11:45:06 +0200 Message-ID: <1274867106.5882.5090.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2010-05-26 at 02:41 -0700, Arve Hjønnevåg wrote: > On Wed, May 26, 2010 at 1:47 AM, Peter Zijlstra wrote: > > On Tue, 2010-05-25 at 01:38 +0200, Rafael J. Wysocki wrote: > >> > This of course will lead to a scattering of suspend blockers into any > >> > drivers/subsystems considered "useful", which by looking through current > >> > Android kernels is many of them. > >> > >> That depends on the maintainers of these subsystems, who still have the power > >> to reject requested changes. > > > > So as a scheduler maintainer I'm going to merge a patch that does a > > suspend_blocker when the runqueue's aren't empty... how about that? > > > > I don't know if you are serious, since the all the runqueues are never > empty while suspending, this would disable opportunistic suspend > altogether. So why again was this such a great scheme? Go fix your userspace to not not run when not needed.