From: Richard Purdie <rpurdie@rpsys.net>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: Axel Lin <axel.lin@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: [PATCH v2] leds-lp3944: properly handle lp3944_configure fail in lp3944_probe
Date: Wed, 26 May 2010 12:31:31 +0100 [thread overview]
Message-ID: <1274873491.16229.84.camel@rex> (raw)
In-Reply-To: <20100517121525.c895d8d9.ospite@studenti.unina.it>
On Mon, 2010-05-17 at 12:15 +0200, Antonio Ospite wrote:
> On Mon, 17 May 2010 17:47:48 +0800
> Axel Lin <axel.lin@gmail.com> wrote:
>
> > In current implementation, lp3944_probe return 0 even if lp3944_configure fail.
> > Therefore, led_classdev_unregister will be executed twice
> > ( in error handling of lp3944_configure and lp3944_remove ).
> > This patch properly handles lp3944_configure fail in lp3944_probe.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Antonio Ospite <ospite@studenti.unina.it>
>
Queued in the leds tree, thanks.
Richard
prev parent reply other threads:[~2010-05-26 11:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 9:47 [PATCH v2] leds-lp3944: properly handle lp3944_configure fail in lp3944_probe Axel Lin
2010-05-17 9:53 ` Wolfram Sang
2010-05-17 10:15 ` Antonio Ospite
2010-05-26 11:31 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274873491.16229.84.camel@rex \
--to=rpurdie@rpsys.net \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ospite@studenti.unina.it \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox