From: Richard Purdie <rpurdie@rpsys.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjarke Istrup Pedersen <gurligebis@gentoo.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: linux-next: build failure after merge of the final tree (leds tree related)
Date: Thu, 27 May 2010 14:07:24 +0100 [thread overview]
Message-ID: <1274965644.24079.1427.camel@rex> (raw)
In-Reply-To: <1274960190.1931.429.camel@pasglop>
On Thu, 2010-05-27 at 21:36 +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2010-05-27 at 15:16 +1000, Stephen Rothwell wrote:
> > Hi Richard,
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/leds/leds-net5501.c:20:23: error: asm/geode.h: No such file or directory
> > drivers/leds/leds-net5501.c: In function 'soekris_init':
> > drivers/leds/leds-net5501.c:63: error: implicit declaration of function 'is_geode'
>
> Looks like something is missing an ifdef CONFIG_X86 :-)
Right, that driver/board is x86 only. I've pushed a fix.
> > Caused by commit 14e40f644b020d473415342461b7c62e3bb5e312 ("leds: Add LED
> > driver for the Soekris net5501 board"). Presumably only tested on x86?
> >
> > drivers/leds/leds-gpio.c: In function 'of_gpio_leds_probe':
> > drivers/leds/leds-gpio.c:253: error: 'struct gpio_led' has no member named 'blinking'
> >
> > Caused by commit 2146325df2c2640059a9e064890c30c6e259b458 ("leds:
> > leds-gpio: Change blink_set callback to be able to turn off blinking").
This error looks like its from Ben's patch, probably when openfirmware
is enabled. I've queued a fix for this too:
http://git.o-hand.com/cgit.cgi/linux-rpurdie-leds/commit/?id=a4b4433c511cf4361bb0afabba69e16632002d32
Cheers,
Richard
next prev parent reply other threads:[~2010-05-27 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 5:16 linux-next: build failure after merge of the final tree (leds tree related) Stephen Rothwell
2010-05-27 11:36 ` Benjamin Herrenschmidt
2010-05-27 13:07 ` Richard Purdie [this message]
2010-05-27 15:35 ` Stephen Rothwell
2010-05-28 0:11 ` Stephen Rothwell
2010-05-28 7:41 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274965644.24079.1427.camel@rex \
--to=rpurdie@rpsys.net \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=gurligebis@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).