* linux-next: build failure after merge of the final tree (leds tree related)
@ 2010-05-27 5:16 Stephen Rothwell
2010-05-27 11:36 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2010-05-27 5:16 UTC (permalink / raw)
To: Richard Purdie
Cc: linux-next, linux-kernel, Bjarke Istrup Pedersen, Randy Dunlap,
Alessandro Zummo, Andrew Morton, Benjamin Herrenschmidt
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
Hi Richard,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/leds/leds-net5501.c:20:23: error: asm/geode.h: No such file or directory
drivers/leds/leds-net5501.c: In function 'soekris_init':
drivers/leds/leds-net5501.c:63: error: implicit declaration of function 'is_geode'
Caused by commit 14e40f644b020d473415342461b7c62e3bb5e312 ("leds: Add LED
driver for the Soekris net5501 board"). Presumably only tested on x86?
drivers/leds/leds-gpio.c: In function 'of_gpio_leds_probe':
drivers/leds/leds-gpio.c:253: error: 'struct gpio_led' has no member named 'blinking'
Caused by commit 2146325df2c2640059a9e064890c30c6e259b458 ("leds:
leds-gpio: Change blink_set callback to be able to turn off blinking").
I have used the version of the leds tree from next-20100526 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build failure after merge of the final tree (leds tree related)
2010-05-27 5:16 linux-next: build failure after merge of the final tree (leds tree related) Stephen Rothwell
@ 2010-05-27 11:36 ` Benjamin Herrenschmidt
2010-05-27 13:07 ` Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2010-05-27 11:36 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Richard Purdie, linux-next, linux-kernel, Bjarke Istrup Pedersen,
Randy Dunlap, Alessandro Zummo, Andrew Morton
On Thu, 2010-05-27 at 15:16 +1000, Stephen Rothwell wrote:
> Hi Richard,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/leds/leds-net5501.c:20:23: error: asm/geode.h: No such file or directory
> drivers/leds/leds-net5501.c: In function 'soekris_init':
> drivers/leds/leds-net5501.c:63: error: implicit declaration of function 'is_geode'
Looks like something is missing an ifdef CONFIG_X86 :-)
Cheers,
Ben.
> Caused by commit 14e40f644b020d473415342461b7c62e3bb5e312 ("leds: Add LED
> driver for the Soekris net5501 board"). Presumably only tested on x86?
>
> drivers/leds/leds-gpio.c: In function 'of_gpio_leds_probe':
> drivers/leds/leds-gpio.c:253: error: 'struct gpio_led' has no member named 'blinking'
>
> Caused by commit 2146325df2c2640059a9e064890c30c6e259b458 ("leds:
> leds-gpio: Change blink_set callback to be able to turn off blinking").
>
> I have used the version of the leds tree from next-20100526 for today.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build failure after merge of the final tree (leds tree related)
2010-05-27 11:36 ` Benjamin Herrenschmidt
@ 2010-05-27 13:07 ` Richard Purdie
2010-05-27 15:35 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2010-05-27 13:07 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Stephen Rothwell, linux-next, linux-kernel,
Bjarke Istrup Pedersen, Randy Dunlap, Alessandro Zummo,
Andrew Morton
On Thu, 2010-05-27 at 21:36 +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2010-05-27 at 15:16 +1000, Stephen Rothwell wrote:
> > Hi Richard,
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/leds/leds-net5501.c:20:23: error: asm/geode.h: No such file or directory
> > drivers/leds/leds-net5501.c: In function 'soekris_init':
> > drivers/leds/leds-net5501.c:63: error: implicit declaration of function 'is_geode'
>
> Looks like something is missing an ifdef CONFIG_X86 :-)
Right, that driver/board is x86 only. I've pushed a fix.
> > Caused by commit 14e40f644b020d473415342461b7c62e3bb5e312 ("leds: Add LED
> > driver for the Soekris net5501 board"). Presumably only tested on x86?
> >
> > drivers/leds/leds-gpio.c: In function 'of_gpio_leds_probe':
> > drivers/leds/leds-gpio.c:253: error: 'struct gpio_led' has no member named 'blinking'
> >
> > Caused by commit 2146325df2c2640059a9e064890c30c6e259b458 ("leds:
> > leds-gpio: Change blink_set callback to be able to turn off blinking").
This error looks like its from Ben's patch, probably when openfirmware
is enabled. I've queued a fix for this too:
http://git.o-hand.com/cgit.cgi/linux-rpurdie-leds/commit/?id=a4b4433c511cf4361bb0afabba69e16632002d32
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build failure after merge of the final tree (leds tree related)
2010-05-27 13:07 ` Richard Purdie
@ 2010-05-27 15:35 ` Stephen Rothwell
2010-05-28 0:11 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2010-05-27 15:35 UTC (permalink / raw)
To: Richard Purdie
Cc: Benjamin Herrenschmidt, linux-next, linux-kernel,
Bjarke Istrup Pedersen, Randy Dunlap, Alessandro Zummo,
Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]
Hi Richard,
On Thu, 27 May 2010 14:07:24 +0100 Richard Purdie <rpurdie@rpsys.net> wrote:
>
> On Thu, 2010-05-27 at 21:36 +1000, Benjamin Herrenschmidt wrote:
> > On Thu, 2010-05-27 at 15:16 +1000, Stephen Rothwell wrote:
> > >
> > > drivers/leds/leds-net5501.c:20:23: error: asm/geode.h: No such file or directory
> > > drivers/leds/leds-net5501.c: In function 'soekris_init':
> > > drivers/leds/leds-net5501.c:63: error: implicit declaration of function 'is_geode'
> >
> > Looks like something is missing an ifdef CONFIG_X86 :-)
>
> Right, that driver/board is x86 only. I've pushed a fix.
>
> > > Caused by commit 14e40f644b020d473415342461b7c62e3bb5e312 ("leds: Add LED
> > > driver for the Soekris net5501 board"). Presumably only tested on x86?
> > >
> > > drivers/leds/leds-gpio.c: In function 'of_gpio_leds_probe':
> > > drivers/leds/leds-gpio.c:253: error: 'struct gpio_led' has no member named 'blinking'
> > >
> > > Caused by commit 2146325df2c2640059a9e064890c30c6e259b458 ("leds:
> > > leds-gpio: Change blink_set callback to be able to turn off blinking").
>
> This error looks like its from Ben's patch, probably when openfirmware
> is enabled. I've queued a fix for this too:
>
> http://git.o-hand.com/cgit.cgi/linux-rpurdie-leds/commit/?id=a4b4433c511cf4361bb0afabba69e16632002d32
Great, thanks.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build failure after merge of the final tree (leds tree related)
2010-05-27 15:35 ` Stephen Rothwell
@ 2010-05-28 0:11 ` Stephen Rothwell
2010-05-28 7:41 ` Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2010-05-28 0:11 UTC (permalink / raw)
To: Richard Purdie
Cc: Benjamin Herrenschmidt, linux-next, linux-kernel,
Bjarke Istrup Pedersen, Randy Dunlap, Alessandro Zummo,
Andrew Morton, Linus
[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]
Hi Richard,
On Fri, 28 May 2010 01:35:49 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Thu, 27 May 2010 14:07:24 +0100 Richard Purdie <rpurdie@rpsys.net> wrote:
> >
> > On Thu, 2010-05-27 at 21:36 +1000, Benjamin Herrenschmidt wrote:
> > > On Thu, 2010-05-27 at 15:16 +1000, Stephen Rothwell wrote:
> > > >
> > > > drivers/leds/leds-net5501.c:20:23: error: asm/geode.h: No such file or directory
> > > > drivers/leds/leds-net5501.c: In function 'soekris_init':
> > > > drivers/leds/leds-net5501.c:63: error: implicit declaration of function 'is_geode'
> > >
> > > Looks like something is missing an ifdef CONFIG_X86 :-)
> >
> > Right, that driver/board is x86 only. I've pushed a fix.
> >
> > > > Caused by commit 14e40f644b020d473415342461b7c62e3bb5e312 ("leds: Add LED
> > > > driver for the Soekris net5501 board"). Presumably only tested on x86?
> > > >
> > > > drivers/leds/leds-gpio.c: In function 'of_gpio_leds_probe':
> > > > drivers/leds/leds-gpio.c:253: error: 'struct gpio_led' has no member named 'blinking'
> > > >
> > > > Caused by commit 2146325df2c2640059a9e064890c30c6e259b458 ("leds:
> > > > leds-gpio: Change blink_set callback to be able to turn off blinking").
> >
> > This error looks like its from Ben's patch, probably when openfirmware
> > is enabled. I've queued a fix for this too:
> >
> > http://git.o-hand.com/cgit.cgi/linux-rpurdie-leds/commit/?id=a4b4433c511cf4361bb0afabba69e16632002d32
>
> Great, thanks.
Except, of course, Linus has merged the broken tree without the fixes :-(
Oh, well.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build failure after merge of the final tree (leds tree related)
2010-05-28 0:11 ` Stephen Rothwell
@ 2010-05-28 7:41 ` Richard Purdie
0 siblings, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2010-05-28 7:41 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Benjamin Herrenschmidt, linux-next, linux-kernel,
Bjarke Istrup Pedersen, Randy Dunlap, Alessandro Zummo,
Andrew Morton, Linus
On Fri, 2010-05-28 at 10:11 +1000, Stephen Rothwell wrote:
> On Fri, 28 May 2010 01:35:49 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Thu, 27 May 2010 14:07:24 +0100 Richard Purdie <rpurdie@rpsys.net> wrote:
> > >
> > > On Thu, 2010-05-27 at 21:36 +1000, Benjamin Herrenschmidt wrote:
> > > > On Thu, 2010-05-27 at 15:16 +1000, Stephen Rothwell wrote:
> > > > >
> > > > > drivers/leds/leds-net5501.c:20:23: error: asm/geode.h: No such file or directory
> > > > > drivers/leds/leds-net5501.c: In function 'soekris_init':
> > > > > drivers/leds/leds-net5501.c:63: error: implicit declaration of function 'is_geode'
> > > >
> > > > Looks like something is missing an ifdef CONFIG_X86 :-)
> > >
> > > Right, that driver/board is x86 only. I've pushed a fix.
> > >
> > > > > Caused by commit 14e40f644b020d473415342461b7c62e3bb5e312 ("leds: Add LED
> > > > > driver for the Soekris net5501 board"). Presumably only tested on x86?
> > > > >
> > > > > drivers/leds/leds-gpio.c: In function 'of_gpio_leds_probe':
> > > > > drivers/leds/leds-gpio.c:253: error: 'struct gpio_led' has no member named 'blinking'
> > > > >
> > > > > Caused by commit 2146325df2c2640059a9e064890c30c6e259b458 ("leds:
> > > > > leds-gpio: Change blink_set callback to be able to turn off blinking").
> > >
> > > This error looks like its from Ben's patch, probably when openfirmware
> > > is enabled. I've queued a fix for this too:
> > >
> > > http://git.o-hand.com/cgit.cgi/linux-rpurdie-leds/commit/?id=a4b4433c511cf4361bb0afabba69e16632002d32
> >
> > Great, thanks.
>
> Except, of course, Linus has merged the broken tree without the fixes :-(
>
> Oh, well.
At least we have fixes, I've asked him to pull them.
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-05-28 7:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-27 5:16 linux-next: build failure after merge of the final tree (leds tree related) Stephen Rothwell
2010-05-27 11:36 ` Benjamin Herrenschmidt
2010-05-27 13:07 ` Richard Purdie
2010-05-27 15:35 ` Stephen Rothwell
2010-05-28 0:11 ` Stephen Rothwell
2010-05-28 7:41 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).