Re: [xfs-masters] [PATCH 11/17] fs/xfs/quota: Add missing mutex_unlock

Eric Sandeen
2010-06-02T03:34:33Z

Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Add a mutex_unlock missing on the error path. The use of this lock is
> balanced elsewhere in the file.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression E1;
> @@
>
> * mutex_lock(E1,...);
> <+... when != E1
> if (...) {
> ... when != E1
> * return ...;
> }
> ...+>
> * mutex_unlock(E1,...);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> The use of ENOMEM rather than -ENOMEM is also a bit odd.

All the xfs core code uses positive errors, it's an irix holdover.

As things bubble up to the vfs interface, signs get switched.

Yeah, it's a bit odd, but nobody dares change it ;)

Maybe semantic patching could fix it ;)

-Eric