From: Peter Zijlstra <peterz@infradead.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Frédéric Weisbecker" <fweisbec@gmail.com>,
"Arnaldo Carvalho de Melo" <acme@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Q] perf, x86: should perf_event_x.c being compiled conditionally?
Date: Sat, 29 May 2010 09:38:57 +0200 [thread overview]
Message-ID: <1275118737.27810.12590.camel@twins> (raw)
In-Reply-To: <20100528213503.GJ20839@lenovo>
On Sat, 2010-05-29 at 01:35 +0400, Cyrill Gorcunov wrote:
> Hi,
>
> while was building the kernel for pretty old laptop I've noticed
> that perf_event_x.c depends on CONFIG_CPU_SUP_ only. So I'm somehow
> confused. Should not some additional condition being used?
>
> For example if a person have Core 2 or Nehalem machine, he will
> definitely not need p6 and p4 events (yes, they are not _that_ big
> in size, but anyway).
>
> On the other hands distro builders would prefer to have all compiled in.
>
> Not sure about what is the best way to resolve this, but perhaps I'm just
> missing some key moment?
We had to split out on the CPU_SUP_* stuff because the AMD support
relies on symbols otherwise not present.
So fixing build dependencies is the main reason we have that.
If you want to extend it, feel free, but be sure to test the
full .config space ;-)
next prev parent reply other threads:[~2010-05-29 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 21:35 [Q] perf, x86: should perf_event_x.c being compiled conditionally? Cyrill Gorcunov
2010-05-29 7:38 ` Peter Zijlstra [this message]
2010-05-29 13:02 ` Cyrill Gorcunov
2010-05-29 13:19 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275118737.27810.12590.camel@twins \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox