From: Nigel Cunningham <nigel@tuxonice.net>
To: "Rafael J. Wysocki" <rjw@sisk.pl>,
Linux PM <linux-pm@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
TuxOnIce-devel <tuxonice-devel@tuxonice.net>
Subject: [PATCH 20/21] Hibernation: Remove swap_map structure
Date: Wed, 2 Jun 2010 22:19:19 +1000 [thread overview]
Message-ID: <1275481160-31150-21-git-send-email-nigel@tuxonice.net> (raw)
In-Reply-To: <1275481160-31150-1-git-send-email-nigel@tuxonice.net>
Remove the now unused swap_map structure and associated
swap_map_handle.
Signed-off-by: Nigel Cunningham <nigel@tuxonice.net>
---
kernel/power/block_io.c | 56 -----------------------------------------------
1 files changed, 0 insertions(+), 56 deletions(-)
diff --git a/kernel/power/block_io.c b/kernel/power/block_io.c
index dd71ef2..5c791c0 100644
--- a/kernel/power/block_io.c
+++ b/kernel/power/block_io.c
@@ -126,40 +126,7 @@ void hib_wait_on_bio_chain(void)
wait_event(num_in_progress_wait, !atomic_read(&hib_io_in_progress));
}
-/*
- * The swap map is a data structure used for keeping track of each page
- * written to a swap partition. It consists of many swap_map_page
- * structures that contain each an array of MAP_PAGE_SIZE swap entries.
- * These structures are stored on the swap and linked together with the
- * help of the .next_swap member.
- *
- * The swap map is created during suspend. The swap map pages are
- * allocated and populated one at a time, so we only need one memory
- * page to set up the entire structure.
- *
- * During resume we also only need to use one swap_map_page structure
- * at a time.
- */
-
-#define MAP_PAGE_ENTRIES (PAGE_SIZE / sizeof(sector_t) - 1)
-
-struct swap_map_page {
- sector_t entries[MAP_PAGE_ENTRIES];
- sector_t next_swap;
-};
-
-/**
- * The swap_map_handle structure is used for handling swap in
- * a file-alike way
- */
-
-struct swap_map_handle {
- struct swap_map_page *cur;
- unsigned int k;
-};
-
static sector_t first_sector;
-static struct swap_map_handle handle;
extern struct hib_extent_state sector_extents;
@@ -207,20 +174,12 @@ static int write_page(void *buf, sector_t offset, int sync)
void release_swap_writer(void)
{
- if (handle.cur)
- free_page((unsigned long)handle.cur);
- handle.cur = NULL;
}
int hib_bio_prepare_write(void)
{
int result, result2;
- handle.cur = (struct swap_map_page *)get_zeroed_page(GFP_KERNEL);
-
- if (!handle.cur)
- return -ENOMEM;
-
result = hib_prepare_buffer();
if (result) {
release_swap_writer();
@@ -232,8 +191,6 @@ int hib_bio_prepare_write(void)
result = hib_extents_store(§or_extents);
result2 = hib_flush_write_buffer();
- handle.k = 0;
-
if (result || result2)
release_swap_writer();
@@ -244,8 +201,6 @@ int swap_write_page(void *buf, int sync)
{
sector_t offset;
- if (!handle.cur)
- return -EINVAL;
offset = hib_extent_next(§or_extents);
return write_page(buf, offset, sync);
}
@@ -263,19 +218,12 @@ int flush_swap_writer(void)
void release_swap_reader(void)
{
- if (handle.cur)
- free_page((unsigned long)handle.cur);
- handle.cur = NULL;
}
int get_swap_reader(unsigned int *flags_p, sector_t first_page)
{
int error;
- handle.cur = (struct swap_map_page *)get_zeroed_page(__GFP_WAIT | __GFP_HIGH);
- if (!handle.cur)
- return -ENOMEM;
-
error = hib_prepare_buffer();
if (error) {
release_swap_reader();
@@ -290,8 +238,6 @@ int get_swap_reader(unsigned int *flags_p, sector_t first_page)
return error;
}
- handle.k = 0;
-
error = hib_extents_load(§or_extents, 1);
if (error) {
@@ -306,8 +252,6 @@ int swap_read_page(void *buf, int sync)
{
sector_t offset;
- if (!handle.cur)
- return -EINVAL;
offset = hib_extent_next(§or_extents);
if (!offset)
return -EFAULT;
--
1.7.0.4
next prev parent reply other threads:[~2010-06-02 12:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 12:18 Nigel's current for-rafael queue Nigel Cunningham
2010-06-02 12:19 ` [PATCH 01/21] Hibernation: Swap iteration functions Nigel Cunningham
2010-06-02 12:19 ` [PATCH 02/21] Hibernation: Move root_swap declaration Nigel Cunningham
2010-06-02 12:19 ` [PATCH 03/21] Hibernation: Add mass swap allocation routine Nigel Cunningham
2010-06-02 12:19 ` [PATCH 04/21] Hibernation: Switch to preallocating swap Nigel Cunningham
2010-06-02 12:19 ` [PATCH 05/21] Hiberation: Fix speed display Nigel Cunningham
2010-06-02 12:19 ` [PATCH 06/21] Hibernation: Generic extents support Nigel Cunningham
2010-06-02 12:19 ` [PATCH 07/21] Hibernation: Iterate over sectors not swap entries Nigel Cunningham
2010-06-02 12:19 ` [PATCH 08/21] Hibernation: Stop passing swap_map_handle struct Nigel Cunningham
2010-06-02 12:19 ` [PATCH 09/21] Hibernation: Stop passing bio_chain around Nigel Cunningham
2010-06-02 12:19 ` [PATCH 10/21] Hibernation: Move block i/o fns to block_io.c Nigel Cunningham
2010-06-02 12:19 ` [PATCH 11/21] Hibernation: Partial page I/O support Nigel Cunningham
2010-06-02 12:19 ` [PATCH 12/21] Hibernation: Extent save/load routines Nigel Cunningham
2010-06-02 12:19 ` [PATCH 13/21] Hibernation: Store block extents at start of image Nigel Cunningham
2010-06-02 12:19 ` [PATCH 14/21] Hibernation: Use block extents for reading image Nigel Cunningham
2010-06-02 12:19 ` [PATCH 15/21] Remove first_sector from swap_map_handle Nigel Cunningham
2010-06-02 12:19 ` [PATCH 16/21] Hibernation: Replace bio chain Nigel Cunningham
2010-06-02 12:19 ` [PATCH 17/21] Hibernation: Remove swap_map_pages Nigel Cunningham
2010-06-02 12:19 ` [PATCH 18/21] Hibernation: Remove wait_on_bio_chain result Nigel Cunningham
2010-06-02 12:19 ` [PATCH 19/21] Hibernation: Prepare for handle.cur removal Nigel Cunningham
2010-06-02 12:19 ` Nigel Cunningham [this message]
2010-06-02 12:19 ` [PATCH 21/21] Hibernation: Remove now-empty routines Nigel Cunningham
2010-08-03 6:55 ` Nigel's current for-rafael queue Pavel Machek
2010-08-03 7:00 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275481160-31150-21-git-send-email-nigel@tuxonice.net \
--to=nigel@tuxonice.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=tuxonice-devel@tuxonice.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).