Re: [GIT PULL] perf crash fix

Peter Zijlstra
2010-06-03T12:40:24Z

On Thu, 2010-06-03 at 14:35 +0200, Frederic Weisbecker wrote:

> I wanted to, but I thought we could avoid two indirect calls on each
> ticks and I was also afraid of breaking start/stop original semantics,
> more especially the role of perf_event_stop/start

Right, so you lost the fallback to ->enable/->disable, which would break
hardware PMU implementations that didn't actually implement
->start/->stop (pretty much all of them except x86).