From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>,
Cyrill Gorcunov <gorcunov@gmail.com>,
Zhang Yanmin <yanmin_zhang@linux.intel.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 3/5] perf: Ability to enable in a paused mode
Date: Sat, 12 Jun 2010 11:44:26 +0200 [thread overview]
Message-ID: <1276335866.2077.3097.camel@twins> (raw)
In-Reply-To: <1276328098-24114-4-git-send-regression-fweisbec@gmail.com>
On Sat, 2010-06-12 at 09:34 +0200, Frederic Weisbecker wrote:
> struct pmu {
> int (*enable) (struct perf_event *event);
> + /*
> + * Reserve acts like enable, except the event must go in a "pause"
> + * state. Ie: it is scheduled but waiting to be started
> + * with the ->start() callback.
> + */
> + int (*reserve) (struct perf_event *event);
> void (*disable) (struct perf_event *event);
Urgh, so then we have, enable(), reserve() and start(), that's just too
much. Also, you need to visit all pmu implementations if you touch
struct pmu like that.
next prev parent reply other threads:[~2010-06-12 9:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-12 7:34 [PATCH 0/5 v3] perf events finer grained context instrumentation / context exclusion Frederic Weisbecker
2010-06-12 7:34 ` [PATCH 1/5] perf: Provide a proper stop action for software events Frederic Weisbecker
2010-06-12 9:43 ` Peter Zijlstra
2010-06-12 16:25 ` Frederic Weisbecker
2010-06-12 7:34 ` [PATCH 2/5] perf: Support disable() after stop() on " Frederic Weisbecker
2010-06-12 7:34 ` [PATCH 3/5] perf: Ability to enable in a paused mode Frederic Weisbecker
2010-06-12 9:44 ` Peter Zijlstra [this message]
2010-06-12 16:44 ` Frederic Weisbecker
2010-06-12 7:34 ` [PATCH 4/5] perf: Introduce task, softirq and hardirq contexts exclusion Frederic Weisbecker
2010-06-12 7:34 ` [PATCH 5/5] perf: Support for task/softirq/hardirq exclusion on tools Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276335866.2077.3097.camel@twins \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox