From: "Alex,Shi" <alex.shi@intel.com>
To: john.r.fastabend@intel.com
Cc: davem@davemloft.net, yanmin.zhang@intel.com,
tim.c.chen@intel.com, linux-kernel@vger.kernel.org
Subject: BUG: aim7/specjbb2005/fio hang due to commit: 597a264b1a9c7e36d1728f
Date: Sun, 13 Jun 2010 14:14:00 +0800 [thread overview]
Message-ID: <1276409640.9452.49.camel@debian> (raw)
The listed benchmark using loopback mode netio and all hang in 35-rc3
testing. Yanmin and I found it is due to the commit
597a264b1a9c7e36d1728f677c66c5c1f7e3b837.
After revert this patch, all benchmarks can be recovered. Seems the
following line is the suspicious.
+ /*
+ * bonding note: skbs received on inactive slaves should only
+ * be delivered to pkt handlers that are exact matches. Also
+ * the deliver_no_wcard flag will be set. If packet handlers
+ * are sensitive to duplicate packets these skbs will need to
+ * be dropped at the handler. The vlan accel path may have
+ * already set the deliver_no_wcard flag.
+ */
null_or_orig = NULL;
orig_dev = skb->dev;
master = ACCESS_ONCE(orig_dev->master);
- if (master) {
- if (skb_bond_should_drop(skb, master))
+ if (skb->deliver_no_wcard)
+ null_or_orig = orig_dev;
+ else if (master) {
+ if (skb_bond_should_drop(skb, master)) {
+ skb->deliver_no_wcard = 1;
null_or_orig = orig_dev; /* deliver only exact
match */
- else
+ } else
skb->dev = master;
}
Thanks
Alex
next reply other threads:[~2010-06-13 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-13 6:14 Alex,Shi [this message]
2010-06-13 8:16 ` BUG: aim7/specjbb2005/fio hang due to commit: 597a264b1a9c7e36d1728f Zhang, Yanmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276409640.9452.49.camel@debian \
--to=alex.shi@intel.com \
--cc=davem@davemloft.net \
--cc=john.r.fastabend@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.c.chen@intel.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).