From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [RFC][PATCH 3/9] replace x86 kvm n_free_mmu_pages with n_used_mmu_pages
Date: Wed, 16 Jun 2010 08:42:28 -0700 [thread overview]
Message-ID: <1276702948.6437.17047.camel@nimitz> (raw)
In-Reply-To: <20100616142541.GB1662@amt.cnet>
On Wed, 2010-06-16 at 11:25 -0300, Marcelo Tosatti wrote:
> > - if (used_pages > kvm_nr_mmu_pages) {
> > - while (used_pages > kvm_nr_mmu_pages &&
> > + if (kvm->arch.n_used_mmu_pages > goal_nr_mmu_pages) {
> > + while (kvm->arch.n_used_mmu_pages > goal_nr_mmu_pages &&
> > !list_empty(&kvm->arch.active_mmu_pages)) {
> > struct kvm_mmu_page *page;
> >
> > page = container_of(kvm->arch.active_mmu_pages.prev,
> > struct kvm_mmu_page, link);
> > - used_pages -= kvm_mmu_zap_page(kvm, page);
> > - used_pages--;
> > + kvm->arch.n_used_mmu_pages -= kvm_mmu_zap_page(kvm, page);
> > + kvm->arch.n_used_mmu_pages--;
>
> kvm->arch.n_used_mmu_pages is deaccounted for in kvm_mmu_zap_page ->
> kvm_mmu_free_page
> already.
Ahh, I see that now. Thanks!
-- Dave
next prev parent reply other threads:[~2010-06-16 15:42 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 13:55 [RFC][PATCH 0/9] rework KVM mmu_shrink() code Dave Hansen
2010-06-15 13:55 ` [RFC][PATCH 1/9] abstract kvm x86 mmu->n_free_mmu_pages Dave Hansen
2010-06-16 8:40 ` Avi Kivity
2010-06-15 13:55 ` [RFC][PATCH 2/9] rename x86 kvm->arch.n_alloc_mmu_pages Dave Hansen
2010-06-15 13:55 ` [RFC][PATCH 3/9] replace x86 kvm n_free_mmu_pages with n_used_mmu_pages Dave Hansen
2010-06-16 14:25 ` Marcelo Tosatti
2010-06-16 15:42 ` Dave Hansen [this message]
2010-06-15 13:55 ` [RFC][PATCH 4/9] create aggregate kvm_total_used_mmu_pages value Dave Hansen
2010-06-16 8:48 ` Avi Kivity
2010-06-16 15:06 ` Dave Hansen
2010-06-17 8:43 ` Avi Kivity
2010-06-16 16:55 ` Dave Hansen
2010-06-17 8:23 ` Avi Kivity
2010-06-15 13:55 ` [RFC][PATCH 5/9] break out some mmu_skrink() code Dave Hansen
2010-06-15 13:55 ` [RFC][PATCH 6/9] remove kvm_freed variable Dave Hansen
2010-06-15 13:55 ` [RFC][PATCH 7/9] make kvm_get_kvm() more robust Dave Hansen
2010-06-15 13:55 ` [RFC][PATCH 8/9] reduce kvm_lock hold times in mmu_skrink() Dave Hansen
2010-06-16 8:54 ` Avi Kivity
2010-06-15 13:55 ` [RFC][PATCH 9/9] make kvm mmu shrinker more aggressive Dave Hansen
2010-06-16 9:24 ` Avi Kivity
2010-06-16 15:25 ` Dave Hansen
2010-06-17 8:37 ` Avi Kivity
2010-06-18 15:49 ` Dave Hansen
2010-06-20 8:11 ` Avi Kivity
2010-06-22 16:32 ` Dave Hansen
2010-07-22 4:36 ` Avi Kivity
2010-07-22 5:36 ` Dave Hansen
2010-07-22 5:42 ` Avi Kivity
2010-06-16 8:38 ` [RFC][PATCH 0/9] rework KVM mmu_shrink() code Avi Kivity
2010-06-16 15:03 ` Dave Hansen
2010-06-17 8:40 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276702948.6437.17047.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).