From: Steven Rostedt <rostedt@goodmis.org>
To: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
Masami Hiramatsu <mhiramat@redhat.com>
Subject: Re: [PATCH] tracing: Fix undelared ENOSYS in include/linux/tracepoint.h
Date: Mon, 21 Jun 2010 10:28:40 -0400 [thread overview]
Message-ID: <1277130520.9181.12.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1277118549-622-1-git-send-email-wuzhangjin@gmail.com>
On Mon, 2010-06-21 at 19:09 +0800, Wu Zhangjin wrote:
> From: Wu Zhangjin <wuzhangjin@gmail.com>
>
> The header file include/linux/tracepoint.h may be included without
> include/linux/errno.h and then the compiler will fail on building for
> undelcared ENOSYS. This patch fixes this problem via including <linux/errno.h>
> to include/linux/tracepoint.h.
>
Hi Wu,
I have not hit this. Did you hit this with mips? Does it need to get
into 2.6.35 or can it wait till 2.6.36?
-- Steve
> Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
> ---
> include/linux/tracepoint.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
> index 9a59d1f..103d1b6 100644
> --- a/include/linux/tracepoint.h
> +++ b/include/linux/tracepoint.h
> @@ -14,6 +14,7 @@
> * See the file COPYING for more details.
> */
>
> +#include <linux/errno.h>
> #include <linux/types.h>
> #include <linux/rcupdate.h>
>
next prev parent reply other threads:[~2010-06-21 14:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 11:09 [PATCH] tracing: Fix undelared ENOSYS in include/linux/tracepoint.h Wu Zhangjin
2010-06-21 14:28 ` Steven Rostedt [this message]
2010-06-21 15:47 ` Mathieu Desnoyers
2010-06-21 16:21 ` Steven Rostedt
2010-06-21 17:41 ` Wu Zhangjin
2010-06-23 15:21 ` [tip:perf/urgent] tracing: Fix undeclared " tip-bot for Wu Zhangjin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277130520.9181.12.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mhiramat@redhat.com \
--cc=mingo@redhat.com \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox