Re: [PATCH v3] drivers: regulator: add Maxim 8998 driver

[Liam Girdwood <lrg@slimlogic.co.uk>]

On Wed, 2010-06-16 at 09:04 +0200, Marek Szyprowski wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
> 
> This patch adds voltage regulator driver for Maxim 8998 chip. This chip
> is used on Samsung Aquila and GONI boards and provides following
> functionalities:
> - 4 BUCK voltage converters, 17 LDO power regulators and 5 other power
>   controllers
> - battery charger
> 
> This patch adds basic driver for voltage regulators and MAX 8998 MFD core.
> 
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> 
> ---
> 
> Changes sinve V2:
> - moved max8998_{read,write,update}_reg function to
>   include/linux/mfd/max8998-private.h
> - removed max8998-rtc definition (rtc subfunction uses different i2c id
>   (mfd functionality is still required for battery charger driver)
> - added iolock mutex to serialize register access correctly
> 
> Changes since V1:
> - converted to MFD framework (for future extensions with RTC and battery
>   charger drivers)
> - removed i2c register cache
> - removed dummy irq support (gpio keys will be used for setting irq_wake)
> - removed static voltage map tables
> - introduced atomic register update io function
> - other code cleanup suggested by Mark Brown

Applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk