linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 5/8 v2]drm:drm_gem Fix  warning: variable 'dev' set but not used
@ 2010-06-21 22:27 Justin P. Mattock
  0 siblings, 0 replies; only message in thread
From: Justin P. Mattock @ 2010-06-21 22:27 UTC (permalink / raw)
  To: dri-devel; +Cc: airlied, linux-kernel, Justin P. Mattock

This is a redu due to the original being completly wrong
(better to leave a warning than shut it off).
I've removed the "dev =" variable but then receive a 
drm_gem.c:207:2: warning: statement with no effect
telling me this thing is not doing anything according to gcc

so the below patch fixes a warning from gcc:
  CC [M]  drivers/gpu/drm/drm_gem.o
drivers/gpu/drm/drm_gem.c: In function 'drm_gem_handle_delete':
drivers/gpu/drm/drm_gem.c:188:21: warning: variable 'dev' set but not used
have a look if you have the time, and if theres something else
to do then let me know(i'll test it out!!) 

 Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

---
 drivers/gpu/drm/drm_gem.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 33dad3f..d1648bf 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -185,7 +185,6 @@ EXPORT_SYMBOL(drm_gem_object_alloc);
 static int
 drm_gem_handle_delete(struct drm_file *filp, u32 handle)
 {
-	struct drm_device *dev;
 	struct drm_gem_object *obj;
 
 	/* This is gross. The idr system doesn't let us try a delete and
@@ -205,7 +204,6 @@ drm_gem_handle_delete(struct drm_file *filp, u32 handle)
 		spin_unlock(&filp->table_lock);
 		return -EINVAL;
 	}
-	dev = obj->dev;
 
 	/* Release reference and decrement refcount. */
 	idr_remove(&filp->object_idr, handle);
-- 
1.7.1.rc1.21.gf3bd6


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-06-21 22:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-21 22:27 [PATCH 5/8 v2]drm:drm_gem Fix warning: variable 'dev' set but not used Justin P. Mattock

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).