From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757031AbbJAVBo (ORCPT ); Thu, 1 Oct 2015 17:01:44 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:61314 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbbJAVBm (ORCPT ); Thu, 1 Oct 2015 17:01:42 -0400 From: Arnd Bergmann To: Lijun Pan Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] fsl-ifc: fix compilation error on ARM's 42 bit VA Date: Thu, 01 Oct 2015 23:01:39 +0200 Message-ID: <12780222.sDbECDi29d@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1443653742-23177-1-git-send-email-Lijun.Pan@freescale.com> <1694323.vYGVsqBdJK@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:1PV0Ekyx/d81VNI+vZ0DZdygr3ezI1R4WUo+pt/hspKAcJLZsGk br4RVbDP/MTWag/tBEilnO4LHNrQdJZObCUJ8RoEj8sAfRmEawaLw2NVOQ/pRoLquE91vQ1 +S9kZNMm64d9GPKqRymVrlbkLrE/Lw2t8Xbu9ZbnZd5AXYPuLHSEQEQ8qf+JCM5pVJ2XDnR fQHKyZNIY4A2hnPJQv0DA== X-UI-Out-Filterresults: notjunk:1;V01:K0:ChiYMs41N6U=:jvYCpm/vMBNJ7XLRTB7RPp 7CH68TfCVh/JQE12gSD0C9EMgCdRV3QXobH9mOQe9dqXwBYFwf2//QM5pNyx/IJxOvplyXkVD KJn77mPBsv0aZLgJOb9hAAf0jNAuUnqmxwmIlqLTSR0jIUEIfd7VhswcTkrqMNcOsluRimKMY Wpn5Xg6CPA+lTJPxMoamwo1L8rxRVh8tvlTrtgkLGRB2kBI1xmjV643MIRko2rzIHsRlpJLAT zvs1MgrSfBF7eTtA71NnOFa1mF0R5bp8HayiuiyoqOB/SHc8C2hx4VVoPzXmB13fV7tPdm/w8 izYbL8pdoyInJcBmKpBeMNdd7SbGGy5ZOb3ufAFG2OVsKAH03ApTd4PU59o0LEnmacwhdqHex HovPMfCxScU87GbuAAcViEPBQhAm3KJdXcHcRz7QNpfje9lD8yCq2bZZ7vPz1J7PEgEZ970pc +pffcqLQ8nZTo7VRW+ctbIhBowwysolblmPTdd2o/nlfO1aaNzpJxr4Q4D124Nm0LxSKIKmzh d52lgoU4RE0OZhxdy1axsiImfc7YmBccZWLEfNkNv/QG9nrE09d6K4cxejPhkZtsSyENgMpvo HXOUxi1Up01zSTShnD3Ylhp2UW6L1ixKQzCMt/C0MRxl7VSJtKy7A7pG/9PTC+DxtzGgE5vE2 xWWAAdvYwNcF+UXiF208k/3bf7nBP2p5iyIKqo1UDbxLjN0AEM7OazglMkPusE1DQBMf/FdEm Vlh4DVjOoZSR9jaz Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 01 October 2015 10:55:16 Lijun Pan wrote: > Lijun Pan > On Oct 1, 2015 3:34 AM, "Arnd Bergmann" wrote: > > > > On Wednesday 30 September 2015 17:55:42 Lijun Pan wrote: > > > Need to include sched.h to fix the following compilation error > > > if FSL_IFC is enabled on ARM64 machine. > > > > That's good, but you did not change the subject line accordingly. > > > > I actually add 'ARM's ' in the subject. > How about I change it to > fsl-ifc: fix compiler error with ARMv8's 42 bit VA and FSL_IFC enabled > I assume above subject is longer than 65 characters. Is that OK to you? > Do you have a better subject in mind? > > Thanks for your kind review. I think the '42 bit VA' part is what is actually misleading, that is the part that confused me. From your description it sounds like the problem is CONFIG_COMPAT being disabled, and that would also be possible with 39-bit VA. Also, it would be clearer to mention ARM64 instead of ARM, as from the kernel's perspective those are two different architectures. How about simply fsl-ifc: add missing include on ARM64 that would be sufficient for readers, and they can get the background from the changelog text. If you want to get more specific, it could be fsl-ifc: add missing include on ARM64 without CONFIG_COMPAT Note that 'missing include' more or less implies a compile error and better describes /what/ the patch does while the changelog describes why we do it (the compiler output and why that happened). Arnd