From: Andy Walls <awalls@md.metrocast.net>
To: Jiri Slaby <jslaby@suse.cz>
Cc: mchehab@infradead.org, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Ian Armstrong <ian@iarmst.demon.co.uk>,
ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] VIDEO: ivtvfb, remove unneeded NULL test
Date: Mon, 05 Jul 2010 12:19:55 -0400 [thread overview]
Message-ID: <1278346795.2229.2.camel@localhost> (raw)
In-Reply-To: <4C31855B.7030509@suse.cz>
On Mon, 2010-07-05 at 09:10 +0200, Jiri Slaby wrote:
> On 07/04/2010 03:22 PM, Andy Walls wrote:
> > On Sun, 2010-07-04 at 09:24 +0200, Jiri Slaby wrote:
> >> On 07/04/2010 06:11 AM, Andy Walls wrote:
> > There are windows of time where a struct device * will exist for a card
> > in the ivtv driver, but a struct v4l2_device * may not: the end of
> > ivtv_remove() and the beginning of ivtv_probe().
>
> If there is no locking or refcounting, this won't change with the added
> check. The window is still there, but it begins after the check with
> your patch. Hence will still cause oopses.
Jiri,
Of course, you're absolutley right.
Please resubmit a version of your original patch fixing both instances
of the check. I'll add my ack and SOB.
If any users ever report an Oops, then I'll bother to add interlocking.
Regards,
Andy
next prev parent reply other threads:[~2010-07-05 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 11:41 [PATCH] VIDEO: ivtvfb, remove unneeded NULL test Jiri Slaby
2010-07-04 4:11 ` Andy Walls
2010-07-04 7:24 ` Jiri Slaby
2010-07-04 13:22 ` Andy Walls
2010-07-05 7:10 ` Jiri Slaby
2010-07-05 16:19 ` Andy Walls [this message]
2010-07-19 17:39 ` [PATCH 1/1] " Jiri Slaby
2010-07-19 21:39 ` Andy Walls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278346795.2229.2.camel@localhost \
--to=awalls@md.metrocast.net \
--cc=ian@iarmst.demon.co.uk \
--cc=ivtv-devel@ivtvdriver.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).