public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* PATCH] Scripts: checkpatch: change externals to globals
@ 2010-07-05 21:34 Joe Eloff
  0 siblings, 0 replies; only message in thread
From: Joe Eloff @ 2010-07-05 21:34 UTC (permalink / raw)
  To: Andy Whitcroft, Andrew Morton, Joe Perches; +Cc: linux-kernel

>From 9745542c84ef223eec8309a9fb7abf225153419d Mon Sep 17 00:00:00 2001
From: Joe Eloff <kagen101@gmail.com>
Date: Mon, 5 Jul 2010 23:28:21 +0200
Subject: [PATCH] Scripts: checkpatch: change externals to globals

Made error message say 'ERROR: do not initialise globals to 0 or NULL'
rather than 'ERROR: do not initialise externals to 0 or NULL'.
Makes more sense in the context since there is an extern keyword in C and
that is a global declaration within the scope of the current file.
Signed-off-by: Joe Eloff <kagen101@gmail.com>
---
 scripts/checkpatch.pl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index bd88f11..6b003cf 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1778,9 +1778,9 @@ sub process {
 			WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
 		}
 
-# check for external initialisers.
+# check for global initialisers.
 		if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) {
-			ERROR("do not initialise externals to 0 or NULL\n" .
+			ERROR("do not initialise globals to 0 or NULL\n" .
 				$herecurr);
 		}
 # check for static initialisers.
-- 
1.6.3.3




^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-07-05 21:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-05 21:34 PATCH] Scripts: checkpatch: change externals to globals Joe Eloff

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox