From: "Justin P. Mattock" <justinmattock@gmail.com>
To: linux-crypto@vger.kernel.org
Cc: davem@davemloft.net, jkosina@suse.cz,
linux-kernel@vger.kernel.org,
"Justin P. Mattock" <justinmattock@gmail.com>
Subject: [PATCH]crypto:hifn_795x.c Fix warning: variable 'ctx' set but not used
Date: Mon, 5 Jul 2010 23:26:14 -0700 [thread overview]
Message-ID: <1278397574-25217-1-git-send-email-justinmattock@gmail.com> (raw)
The below fixes a warning message generated by GCC
CC [M] drivers/crypto/hifn_795x.o
drivers/crypto/hifn_795x.c: In function 'hifn_flush':
drivers/crypto/hifn_795x.c:2021:23: warning: variable 'ctx' set but not used
drivers/crypto/hifn_795x.c: In function 'hifn_process_queue':
drivers/crypto/hifn_795x.c:2142:23: warning: variable 'ctx' set but not used
Please have a look, and let me know if this is legit or not.
Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
---
drivers/crypto/hifn_795x.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
index 16fce3a..e7aa4dc 100644
--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/crypto/hifn_795x.c
@@ -2036,6 +2036,11 @@ static void hifn_flush(struct hifn_device *dev)
spin_lock_irqsave(&dev->lock, flags);
while ((async_req = crypto_dequeue_request(&dev->queue))) {
ctx = crypto_tfm_ctx(async_req->tfm);
+ if (ctx) {
+ dprintk("%s: Flushing shash. %s\n",
+ dev->name, ctx);
+ return;
+ }
req = container_of(async_req, struct ablkcipher_request, base);
spin_unlock_irqrestore(&dev->lock, flags);
@@ -2157,6 +2162,11 @@ static int hifn_process_queue(struct hifn_device *dev)
backlog->complete(backlog, -EINPROGRESS);
ctx = crypto_tfm_ctx(async_req->tfm);
+ if (ctx) {
+ dprintk("%s: shash in queue. %s\n",
+ dev->name, ctx);
+ return 0;
+ }
req = container_of(async_req, struct ablkcipher_request, base);
err = hifn_handle_req(req);
--
1.7.1.rc1.21.gf3bd6
next reply other threads:[~2010-07-06 6:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 6:26 Justin P. Mattock [this message]
2010-07-06 7:03 ` [PATCH]crypto:hifn_795x.c Fix warning: variable 'ctx' set but not used Herbert Xu
2010-07-06 13:46 ` Justin P. Mattock
2010-07-06 17:19 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278397574-25217-1-git-send-email-justinmattock@gmail.com \
--to=justinmattock@gmail.com \
--cc=davem@davemloft.net \
--cc=jkosina@suse.cz \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox