Re: [PATCH 1/9] of: move phandle/ihandle into types.h

Andres Salomon
2010-09-03T07:33:12Z

On Mon, 30 Aug 2010 07:06:27 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:

> On Sun, Aug 29, 2010 at 11:53:52PM -0400, Andres Salomon wrote:
> >
> > We need phandle for some exported sparc headers; of.h isn't an
> > exported header, and it would be silly to export it when all we
> > really need is one or two types from it. So, move the
> > phandle/ihandle definitions into types.h.
> >
> > diff --git a/include/linux/types.h b/include/linux/types.h
> > index 01a082f..26526ea 100644
> > --- a/include/linux/types.h
> > +++ b/include/linux/types.h
> > @@ -219,6 +219,10 @@ struct ustat {
> > char f_fpack[6];
> > };
> >
> > +/* Basic openboot/openfirmware types */
> > +typedef u32 phandle;
> > +typedef u32 ihandle;
> > +
> > #endif /* __KERNEL__ */
>
> The above is inside #ifdef __KERNEL__ / #endif
> so it is not exported as we drop code protected
> by __KERNEL__ when we prepare for export.

At least for me, that's fine; I don't need phandle/ihandle to be
available to userspace. The folks who work on the userspace fdt code
may feel differently, however.

(I'm not sure if you're suggesting it be outside the __KERNEL__ ifdef
or not..)

>
> Id addition "phandle" and "ihandle" needs to have
> two underscores apended as we cannot just add the above
> to the userspace namespace and expect it to be OK.
>
> We do this for many other typers already, see __u32 for example.
>
> Sam