From: john stultz <johnstul@us.ibm.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
eric.dumazet@gmail.com, oleg@redhat.com
Subject: Re: [PATCH] time/fs - file's time race with vgettimeofday
Date: Wed, 07 Jul 2010 10:20:30 -0700 [thread overview]
Message-ID: <1278523230.2635.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20100707171103.GB20533@jolsa.brq.redhat.com>
On Wed, 2010-07-07 at 19:11 +0200, Jiri Olsa wrote:
> On Tue, Jul 06, 2010 at 04:11:40PM -0700, john stultz wrote:
> > - vgettimeofday(&tv, NULL);
> > - result = tv.tv_sec;
> > + do {
> > + seq = read_seqbegin(&__vsyscall_gtod_data.lock);
> > +
> > + result = vsyscall_gtod_data.wall_time_sec;
> > +
> > + } while (read_seqretry(&__vsyscall_gtod_data.lock, seq));
> > +
> > if (t)
> > *t = result;
> > return result;
> >
> >
>
> I think there's a typo in using "vsyscall_gtod_data" inside
> the vtime call it should be "__vsyscall_gtod_data" intead.
Quite right! Thanks for catching it!
-john
prev parent reply other threads:[~2010-07-07 17:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 7:41 [PATCH] time/fs - file's time race with vgettimeofday Jiri Olsa
2010-07-02 16:14 ` Oleg Nesterov
2010-07-02 16:20 ` Oleg Nesterov
2010-07-02 23:58 ` Jiri Olsa
2010-07-06 23:03 ` john stultz
2010-07-06 23:11 ` john stultz
2010-07-07 10:47 ` Jiri Olsa
2010-07-07 16:20 ` john stultz
2010-07-07 17:11 ` Jiri Olsa
2010-07-07 17:20 ` john stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278523230.2635.2.camel@localhost.localdomain \
--to=johnstul@us.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox