linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
	josh@joshtriplett.org, dvhltc@us.ibm.com, niv@us.ibm.com,
	tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org,
	Valdis.Kletnieks@vt.edu, dhowells@redhat.com,
	eric.dumazet@gmail.com,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH RFC tip/core/rcu 22/30] rcu: make CPU stall warning timeout configurable
Date: Wed, 14 Jul 2010 13:09:56 -0700	[thread overview]
Message-ID: <1279138204-12849-22-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <20100714200945.GA10535@linux.vnet.ibm.com>

Also set the default to 60 seconds, up from the previous hard-coded timeout
of 10 seconds.  This allows people who care to set short timeouts, while
avoiding people with unusual configurations (make randconfig!!!) from being
bothered with spurious CPU stall warnings.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
 kernel/rcutree.h  |    5 +++--
 lib/Kconfig.debug |   11 +++++++++++
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/kernel/rcutree.h b/kernel/rcutree.h
index 14c040b..5d68e17 100644
--- a/kernel/rcutree.h
+++ b/kernel/rcutree.h
@@ -254,9 +254,10 @@ struct rcu_data {
 #define RCU_STALL_DELAY_DELTA	       0
 #endif
 
-#define RCU_SECONDS_TILL_STALL_CHECK   (10 * HZ + RCU_STALL_DELAY_DELTA)
+#define RCU_SECONDS_TILL_STALL_CHECK   (CONFIG_RCU_CPU_STALL_TIMEOUT * HZ + \
+					RCU_STALL_DELAY_DELTA)
 						/* for rsp->jiffies_stall */
-#define RCU_SECONDS_TILL_STALL_RECHECK (30 * HZ + RCU_STALL_DELAY_DELTA)
+#define RCU_SECONDS_TILL_STALL_RECHECK (3 * RCU_SECONDS_TILL_STALL_CHECK + 30)
 						/* for rsp->jiffies_stall */
 #define RCU_STALL_RAT_DELAY		2	/* Allow other CPUs time */
 						/*  to take at least one */
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index a8a272a..af8b9c5 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -821,6 +821,17 @@ config RCU_CPU_STALL_DETECTOR
 
 	  Say Y if you are unsure.
 
+config RCU_CPU_STALL_TIMEOUT
+	int "RCU CPU stall timeout in seconds"
+	depends on RCU_CPU_STALL_DETECTOR
+	range 3 300
+	default 60
+	help
+	  If a given RCU grace period extends more than the specified
+	  number of seconds, a CPU stall warning is printed.  If the
+	  RCU grace period persists, additional CPU stall warnings are
+	  printed at more widely spaced intervals.
+
 config RCU_CPU_STALL_VERBOSE
 	bool "Print additional per-task information for RCU_CPU_STALL_DETECTOR"
 	depends on RCU_CPU_STALL_DETECTOR && TREE_PREEMPT_RCU
-- 
1.7.0.6


  parent reply	other threads:[~2010-07-14 20:12 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-14 20:09 [PATCH RFC tip/core/rcu 0/30] RCU commits queued for 2.6.36/7 Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 01/30] net: convert to rcu_dereference_index_check() Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 02/30] rcu: define __rcu address space modifier for sparse Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 03/30] rculist: avoid __rcu annotations Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 04/30] cgroups: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 05/30] credentials: rcu annotation Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 06/30] keys: __rcu annotations Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 07/30] nfs: " Paul E. McKenney
2010-07-14 22:07   ` Trond Myklebust
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 08/30] net: __rcu annotations for drivers Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 09/30] perf_event: __rcu annotations Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 10/30] notifiers: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 11/30] radix-tree: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 12/30] idr: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 13/30] input: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 14/30] net/netfilter: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 15/30] kvm: add " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 16/30] kernel: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 17/30] net: " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 18/30] kvm: more " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 19/30] vhost: add " Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 20/30] Update documentation to note the passage of INIT_RCU_HEAD() Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 21/30] Update call_rcu() usage, add synchronize_rcu() Paul E. McKenney
2010-07-14 20:09 ` Paul E. McKenney [this message]
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 23/30] rcu head remove init Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 24/30] rcu: add shiny new debug assists to Documentation/RCU/checklist.txt Paul E. McKenney
2010-07-14 20:09 ` [PATCH RFC tip/core/rcu 25/30] rcutorture: add random preemption Paul E. McKenney
2010-07-14 20:10 ` [PATCH RFC tip/core/rcu 26/30] rcu: simplify the usage of percpu data Paul E. McKenney
2010-07-14 20:10 ` [PATCH RFC tip/core/rcu 27/30] rcu: apply ->rda changes to rcutree_trace.c Paul E. McKenney
2010-07-14 21:12   ` Josh Triplett
2010-07-14 21:16     ` Paul E. McKenney
2010-07-14 20:10 ` [PATCH RFC tip/core/rcu 28/30] rcu: rename __do_rcu_dereference_check() to rcu_lockdep_assert() Paul E. McKenney
2010-07-14 20:10 ` [PATCH RFC tip/core/rcu 29/30] rcu: add boot parameter to suppress RCU CPU stall warning messages Paul E. McKenney
2010-07-14 21:16   ` Josh Triplett
2010-07-14 23:30     ` Paul E. McKenney
2010-07-14 20:10 ` [PATCH RFC tip/core/rcu 30/30] rcu: improve kerneldoc for rcu_read_lock(), call_rcu(), and synchronize_rcu() Paul E. McKenney
2010-07-14 21:19 ` [PATCH RFC tip/core/rcu 0/30] RCU commits queued for 2.6.36/7 Josh Triplett
2010-07-14 23:27   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1279138204-12849-22-git-send-email-paulmck@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=dvhltc@us.ibm.com \
    --cc=eric.dumazet@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=niv@us.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).