From: Nathan Lynch <ntl@pobox.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Davide Libenzi <davidel@xmailserver.org>,
stable@kernel.org
Subject: Re: [PATCH] signalfd: fill in ssi_int for posix timers and message queues
Date: Wed, 21 Jul 2010 12:39:37 -0500 [thread overview]
Message-ID: <1279733977.3030.256.camel@localhost> (raw)
In-Reply-To: <20100720211018.e586c7ce.akpm@linux-foundation.org>
On Tue, 2010-07-20 at 21:10 -0700, Andrew Morton wrote:
> On Tue, 20 Jul 2010 22:44:19 -0500 Nathan Lynch <ntl@pobox.com> wrote:
>
> > > So it's not 100% obvious that this change is desirable. Does the
> > > functionality which this patch adds justify the introduction of these
> > > problems?
> >
> > I think the change is desirable in that no user of the interface could
> > reasonably expect the current behavior with respect to the ssi_int
> > field, and that it reconciles signalfd's behavior with its design
> > intentions. On the other hand, I noticed this discrepancy only because
> > I was cribbing signalfd's data structures for checkpoint/restart, not
> > because I am aware of any application that is affected, nor was I able
> > to find one using Google's code search. It would be highly speculative
> > of me to say that no application depends on the current behavior, but it
> > is difficult to imagine a correctly functioning application that depends
> > on it.
>
> It's not a matter of a current application depending on current
> behaviour! The problem is that an application written in 2018 which
> depends on the _new_ behaviour will not work on 2.6.34.
Yes, I misinterpreted your concern, sorry. But I've never understood
Linux to make promises with respect to forward compatibility at the
system call layer. Bug fixes[1] and features[2] that, like this patch,
break that compatibility seem to have gone in without raising this
issue.
Am I mistaken? Or has there been a change in policy I've missed?
[1] "signalfd: fix for incorrect SI_QUEUE user data reporting" (0859ab5)
[2] "hugetlb: add MAP_HUGETLB for mmaping pseudo-anonymous huge page
regions" (4e52780)
next prev parent reply other threads:[~2010-07-21 17:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 0:38 [PATCH] signalfd: fill in ssi_int for posix timers and message queues Nathan Lynch
2010-07-03 19:09 ` Davide Libenzi
2010-07-05 12:22 ` Nathan Lynch
2010-07-05 18:23 ` Davide Libenzi
2010-07-20 22:42 ` Andrew Morton
2010-07-21 3:44 ` Nathan Lynch
2010-07-21 4:10 ` Andrew Morton
2010-07-21 17:39 ` Nathan Lynch [this message]
2010-07-25 4:09 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279733977.3030.256.camel@localhost \
--to=ntl@pobox.com \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox