* [RFC][PATCH v1 11/15] perf: export tracepoint events via sysfs: power
@ 2010-07-22 11:17 Lin Ming
2010-07-22 21:53 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Lin Ming @ 2010-07-22 11:17 UTC (permalink / raw)
To: Ingo Molnar, Rafael J. Wysocki
Cc: Robert Richter, Corey Ashford, Johannes Berg, Peter Zijlstra,
Greg KH, Frederic Weisbecker, Paul Mundt, eranian@gmail.com,
Gary.Mohr@Bull.com, arjan@linux.intel.com, Zhang, Yanmin,
Paul Mackerras, David S. Miller, Russell King,
Arnaldo Carvalho de Melo, Will Deacon, Maynard Johnson, Carl Love,
Kay Sievers, lkml, Thomas Gleixner, Steven Rostedt
power tracepoint events are exported like below,
/sys/power/events/
|-- power_end
| |-- config
| `-- type
|-- power_frequency
| |-- config
| `-- type
`-- power_start
|-- config
`-- type
---
kernel/power/main.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/kernel/power/main.c b/kernel/power/main.c
index b58800b..6749374 100644
--- a/kernel/power/main.c
+++ b/kernel/power/main.c
@@ -12,6 +12,7 @@
#include <linux/string.h>
#include <linux/resume-trace.h>
#include <linux/workqueue.h>
+#include <linux/perf_event.h>
#include "power.h"
@@ -269,6 +270,9 @@ static int __init pm_init(void)
power_kobj = kobject_create_and_add("power", NULL);
if (!power_kobj)
return -ENOMEM;
+
+ perf_sys_add_tp(power_kobj, "power");
+
return sysfs_create_group(power_kobj, &attr_group);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC][PATCH v1 11/15] perf: export tracepoint events via sysfs: power
2010-07-22 11:17 [RFC][PATCH v1 11/15] perf: export tracepoint events via sysfs: power Lin Ming
@ 2010-07-22 21:53 ` Rafael J. Wysocki
[not found] ` <AANLkTincVAsbxJk0IR4mkdP1kIuefQiSxy--_0Xeskbc@mail.gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2010-07-22 21:53 UTC (permalink / raw)
To: Lin Ming
Cc: Ingo Molnar, Robert Richter, Corey Ashford, Johannes Berg,
Peter Zijlstra, Greg KH, Frederic Weisbecker, Paul Mundt,
eranian@gmail.com, Gary.Mohr@Bull.com, arjan@linux.intel.com,
Zhang, Yanmin, Paul Mackerras, David S. Miller, Russell King,
Arnaldo Carvalho de Melo, Will Deacon, Maynard Johnson, Carl Love,
Kay Sievers, lkml, Thomas Gleixner, Steven Rostedt
On Thursday, July 22, 2010, Lin Ming wrote:
> power tracepoint events are exported like below,
>
> /sys/power/events/
> |-- power_end
> | |-- config
> | `-- type
> |-- power_frequency
> | |-- config
> | `-- type
> `-- power_start
> |-- config
> `-- type
Any details?
> ---
> kernel/power/main.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index b58800b..6749374 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -12,6 +12,7 @@
> #include <linux/string.h>
> #include <linux/resume-trace.h>
> #include <linux/workqueue.h>
> +#include <linux/perf_event.h>
>
> #include "power.h"
>
> @@ -269,6 +270,9 @@ static int __init pm_init(void)
> power_kobj = kobject_create_and_add("power", NULL);
> if (!power_kobj)
> return -ENOMEM;
> +
> + perf_sys_add_tp(power_kobj, "power");
> +
Why isn't it done in drivers/base/power/sysfs.c ?
> return sysfs_create_group(power_kobj, &attr_group);
> }
Rafael
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fwd: [RFC][PATCH v1 11/15] perf: export tracepoint events via sysfs: power
[not found] ` <AANLkTincVAsbxJk0IR4mkdP1kIuefQiSxy--_0Xeskbc@mail.gmail.com>
@ 2010-07-23 2:00 ` Lin Ming
2010-07-23 11:58 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Lin Ming @ 2010-07-23 2:00 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Ingo Molnar, Robert Richter, Corey Ashford, Johannes Berg,
Peter Zijlstra, Greg KH, Frederic Weisbecker, Paul Mundt,
eranian@gmail.com, Gary.Mohr@Bull.com, arjan@linux.intel.com,
Zhang, Yanmin, Paul Mackerras, David S. Miller, Russell King,
Arnaldo Carvalho de Melo, Will Deacon, Maynard Johnson, Carl Love,
Kay Sievers, lkml, Thomas Gleixner, Steven Rostedt
> From: Rafael J. Wysocki <rjw@sisk.pl>
> Date: Fri, Jul 23, 2010 at 5:53 AM
> Subject: Re: [RFC][PATCH v1 11/15] perf: export tracepoint events via
> sysfs: power
>
>
> On Thursday, July 22, 2010, Lin Ming wrote:
> > power tracepoint events are exported like below,
> >
> > /sys/power/events/
> > |-- power_end
> > | |-- config
> > | `-- type
> > |-- power_frequency
> > | |-- config
> > | `-- type
> > `-- power_start
> > |-- config
> > `-- type
>
> Any details?
Sorry that I didn't include you in the patch description.
[RFC][PATCH v1 00/15] perf: export events in a structured way via sysfs
http://lkml.org/lkml/2010/7/22/141
>
> > ---
> > kernel/power/main.c | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/kernel/power/main.c b/kernel/power/main.c
> > index b58800b..6749374 100644
> > --- a/kernel/power/main.c
> > +++ b/kernel/power/main.c
> > @@ -12,6 +12,7 @@
> > #include <linux/string.h>
> > #include <linux/resume-trace.h>
> > #include <linux/workqueue.h>
> > +#include <linux/perf_event.h>
> >
> > #include "power.h"
> >
> > @@ -269,6 +270,9 @@ static int __init pm_init(void)
> > power_kobj = kobject_create_and_add("power", NULL);
> > if (!power_kobj)
> > return -ENOMEM;
> > +
> > + perf_sys_add_tp(power_kobj, "power");
> > +
>
> Why isn't it done in drivers/base/power/sysfs.c ?
The sysfs thing in drivers/base/power/sysfs.c is per device.
But the power tracepoint events are not per device, right?
Lin Ming
>
> > return sysfs_create_group(power_kobj, &attr_group);
> > }
>
> Rafael
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fwd: [RFC][PATCH v1 11/15] perf: export tracepoint events via sysfs: power
2010-07-23 2:00 ` Fwd: " Lin Ming
@ 2010-07-23 11:58 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2010-07-23 11:58 UTC (permalink / raw)
To: Lin Ming
Cc: Ingo Molnar, Robert Richter, Corey Ashford, Johannes Berg,
Peter Zijlstra, Greg KH, Frederic Weisbecker, Paul Mundt,
eranian@gmail.com, Gary.Mohr@Bull.com, arjan@linux.intel.com,
Zhang, Yanmin, Paul Mackerras, David S. Miller, Russell King,
Arnaldo Carvalho de Melo, Will Deacon, Maynard Johnson, Carl Love,
Kay Sievers, lkml, Thomas Gleixner, Steven Rostedt
On Friday, July 23, 2010, Lin Ming wrote:
>
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> > Date: Fri, Jul 23, 2010 at 5:53 AM
> > Subject: Re: [RFC][PATCH v1 11/15] perf: export tracepoint events via
> > sysfs: power
> >
> >
> > On Thursday, July 22, 2010, Lin Ming wrote:
> > > power tracepoint events are exported like below,
> > >
> > > /sys/power/events/
> > > |-- power_end
> > > | |-- config
> > > | `-- type
> > > |-- power_frequency
> > > | |-- config
> > > | `-- type
> > > `-- power_start
> > > |-- config
> > > `-- type
> >
> > Any details?
>
> Sorry that I didn't include you in the patch description.
>
> [RFC][PATCH v1 00/15] perf: export events in a structured way via sysfs
> http://lkml.org/lkml/2010/7/22/141
Thanks, I'll have a look at this later today.
> > > ---
> > > kernel/power/main.c | 4 ++++
> > > 1 files changed, 4 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/kernel/power/main.c b/kernel/power/main.c
> > > index b58800b..6749374 100644
> > > --- a/kernel/power/main.c
> > > +++ b/kernel/power/main.c
> > > @@ -12,6 +12,7 @@
> > > #include <linux/string.h>
> > > #include <linux/resume-trace.h>
> > > #include <linux/workqueue.h>
> > > +#include <linux/perf_event.h>
> > >
> > > #include "power.h"
> > >
> > > @@ -269,6 +270,9 @@ static int __init pm_init(void)
> > > power_kobj = kobject_create_and_add("power", NULL);
> > > if (!power_kobj)
> > > return -ENOMEM;
> > > +
> > > + perf_sys_add_tp(power_kobj, "power");
> > > +
> >
> > Why isn't it done in drivers/base/power/sysfs.c ?
>
> The sysfs thing in drivers/base/power/sysfs.c is per device.
> But the power tracepoint events are not per device, right?
Right, sorry.
Rafael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-23 12:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-22 11:17 [RFC][PATCH v1 11/15] perf: export tracepoint events via sysfs: power Lin Ming
2010-07-22 21:53 ` Rafael J. Wysocki
[not found] ` <AANLkTincVAsbxJk0IR4mkdP1kIuefQiSxy--_0Xeskbc@mail.gmail.com>
2010-07-23 2:00 ` Fwd: " Lin Ming
2010-07-23 11:58 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).