Re: [PATCHv5 00/15] kill unnecessary bdi wakeups + cleanups

Artem Bityutskiy
2010-07-25T09:08:46Z

On Sun, 2010-07-25 at 11:29 +0300, Artem Bityutskiy wrote:
> Changes since v4
> Most patches are intact. Only patches N9, N10 and N14 were changed. And patch
> N15 was added. Also, now I tested the patch-set much better.
>
> 1. Fix a bug found while testing: in the forker thread, when we create a bdi
> task and then assign it to 'bdi->wb.task', we need to take the
> 'bdi->work_lock'. Otherwise we can lose a wake-up. Changed this in patch
> N10.
> 2. Add patch 15 which fixes a warning and cleans up 'bdi_register()'.
> 3. Use "switch" in the main forker thread loop. Patch N9 was changed and now it
> also introduces the "switch".
> 4. Stick with Christoph's version of tracepoint names and positions -> changed
> patch N14.
> 5. Add a couple of "Reviewed-by" tags.

Oh, completely forgot to mention another thing.

6. Addressed the issue pointed to by Christoph and added
'del_timer_sync()'

So patch N12 was also tweaked.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)