From: Matt Mackall <mpm@selenic.com>
To: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: Herbert Xu <herbert@gondor.hengli.com.au>,
Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] random: reorder struct entropy_store to remove padding on 64bits
Date: Wed, 28 Jul 2010 11:02:28 -0500 [thread overview]
Message-ID: <1280332948.11415.705.camel@calx> (raw)
In-Reply-To: <1280309521.2029.5.camel@castor.rsk>
On Wed, 2010-07-28 at 10:32 +0100, Richard Kennedy wrote:
> Re-order structure entropy_store to remove 8 bytes of padding on
> 64 bit builds, so shrinking this structure from 72 to 64 bytes
> and allowing it to fit into one cache line.
I have a vague memory that we reordered things so that the r/w bits
would be on a separate cache line than the r/o bits. But as we never
added the alignment primitives to actually enforce that, I guess it
doesn't matter much.
> Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Matt Mackall <mpm@selenic.com>
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2010-07-28 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-28 9:32 [PATCH] random: reorder struct entropy_store to remove padding on 64bits Richard Kennedy
2010-07-28 16:02 ` Matt Mackall [this message]
2010-07-31 11:58 ` Herbert Xu
2010-07-31 13:36 ` Matt Mackall
2010-07-31 15:14 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280332948.11415.705.camel@calx \
--to=mpm@selenic.com \
--cc=akpm@linux-foundation.org \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@rsk.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox