public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick Pannuto <ppannuto@codeaurora.org>
To: linux-kernel@vger.kernel.org
Cc: ppannuto@codeaurora.org, apw@canonical.com, corbet@lwn.net
Subject: [PATCH v2 0/4] timer: Added usleep[_range] timer
Date: Wed, 28 Jul 2010 12:33:03 -0700	[thread overview]
Message-ID: <1280345587-19725-1-git-send-email-ppannuto@codeaurora.org> (raw)

After writing both documentation and a checkpatch rule explaining
why the usleep API should never be used, it occurred to me that
perhaps such an API should never be added :) - at least not in its
previous form.

This iteration is similar, with the notable difference that now
usleep has a "built-in slack" of 200%. This is analogous to msleep,
which has a built-in slack of 0.4% (since it relies on legacy timers,
which have a built-in slack of 0.4%). 200% slack is significantly
greater than 0.4%, but the scale of usleep is also significantly
different than that of msleep, and I believe 200% to be a sane
default.

It is my opinion that this interface will most often mirror what
developers actually intend - indeed some people who have begun
trying to use the API raised this point -, however, I would like
some input as it is possibly confusing that the API will "double
your sleep" by default.

The usleep_range API is still included, since it provides an
interface to override the "default slack" of 200% by providing
an explicit range, or to allow callers to specify an even larger
slack if possible.


This patch series is NOT based off of tip (read: it will conflict
with the previous usleep patch in -mm) since it is slighly
different, and Andrew Morton lamented to loss of the detailed
changelog info in the previous iteration - it is included here.

This series also includes the "full set", that is
   1: Adds the usleep[_range] API
   2: Adds timers-howto documentation
   3: Checkpatch: prefer usleep over udelay
   4: Checkpatch: warn about unexpectedly long msleep's


*** Changes in v2
   * Add "default slack" to usleep
   * Fix missing usec->nsec for delta in do_usleep_range
   * Fix Documentation typos
   * Better checkpatch regex's


             reply	other threads:[~2010-07-28 19:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28 19:33 Patrick Pannuto [this message]
2010-07-28 19:33 ` [PATCH 1/4] timer: Added usleep[_range] timer Patrick Pannuto
2010-07-28 20:23   ` Andrew Morton
2010-07-28 20:47     ` Patrick Pannuto
2010-07-28 20:58       ` Andrew Morton
2010-07-28 21:04         ` Arjan van de Ven
2010-07-28 21:11           ` Patrick Pannuto
2010-07-28 21:22           ` Andrew Morton
2010-07-28 21:25             ` Arjan van de Ven
2010-07-28 21:05         ` Patrick Pannuto
2010-07-28 21:23           ` Andrew Morton
2010-07-28 21:26             ` Arjan van de Ven
2010-07-28 19:33 ` [PATCH 2/4] Documentation: Add timers/timers-howto.txt Patrick Pannuto
2010-07-28 19:33 ` [PATCH 3/4] Checkpatch: prefer usleep over udelay Patrick Pannuto
2010-07-28 20:24   ` Andrew Morton
2010-07-28 19:33 ` [PATCH 4/4] Checkpatch: warn about unexpectedly long msleep's Patrick Pannuto
2010-07-28 20:24   ` Andrew Morton
2010-07-28 20:48     ` Patrick Pannuto
2010-08-03 19:12 ` [PATCH v2 0/4] timer: Added usleep[_range] timer Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280345587-19725-1-git-send-email-ppannuto@codeaurora.org \
    --to=ppannuto@codeaurora.org \
    --cc=apw@canonical.com \
    --cc=corbet@lwn.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox