From: Maxim Levitsky <maximlevitsky@gmail.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
"ath5k-devel@lists.ath5k.org" <ath5k-devel@venema.h4ckr.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
David Quan <David.Quan@atheros.com>,
"Luis R. Rodriguez" <mcgrof@bombadil.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"kernel-team@lists.ubuntu.com" <kernel-team@lists.ubuntu.com>,
Luis Rodriguez <Luis.Rodriguez@atheros.com>,
Jussi Kivilinna <jussi.kivilinna@mbnet.fi>,
"tim.gardner@canonical.com" <tim.gardner@canonical.com>
Subject: Re: [ath5k-devel] [PATCH v3] ath5k: disable ASPM
Date: Thu, 29 Jul 2010 02:48:15 +0300 [thread overview]
Message-ID: <1280360895.8891.19.camel@maxim-laptop> (raw)
In-Reply-To: <AANLkTim1sZ5ZoGcrsdCw8dFSzUj4igZOiq7irKsdbfXR@mail.gmail.com>
On Tue, 2010-07-27 at 08:57 -0700, Luis R. Rodriguez wrote:
> On Tue, Jul 27, 2010 at 2:35 AM, Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> > On Mon, 2010-07-26 at 23:50 +0100, Matthew Garrett wrote:
> >> On Mon, Jul 26, 2010 at 03:43:04PM -0700, Luis R. Rodriguez wrote:
> >>
> >> > I see.. thanks Mathew... in that case since L1 works on all devices we
> >> > could just force enable L1 for all PCIE devices. What do you think?
> >>
> >> Works for me.
> >>
> >
> > On the second thought, there is no 'pci_enable_link_state' :-)
> > I afraid that if I add it, I might not do that right for all cases, thus
> > do more harm that good...
>
> I'm sorry, can you elaborate?
I mean ASPM code doesn't have a function to undo effects of the
blacklist (due to pre 1.1 pcie device).
Its not that simple to write such function.
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2010-07-28 23:48 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100528100901.14580.1322.stgit@fate.lan>
[not found] ` <20100528212523.213125g8t0an4mn4@hayate.sektori.org>
[not found] ` <1275078476.18152.10.camel@mj>
[not found] ` <201005311006.15282.br1@einfach.org>
2010-06-01 20:43 ` [ath5k-devel] [PATCH] ath5k: disable ASPM Luis R. Rodriguez
[not found] ` <1276806785.20754.8.camel@maxim-laptop>
[not found] ` <20100618112026.17623g6uhdjk8hts@naisho.dyndns.info>
[not found] ` <1276856142.9114.1.camel@maxim-laptop>
[not found] ` <20100618134930.124225d4fsi8w1fk@naisho.dyndns.info>
2010-06-18 11:05 ` Maxim Levitsky
2010-06-18 13:59 ` Bob Copeland
2010-06-18 14:11 ` Maxim Levitsky
2010-06-19 7:49 ` [PATCH v2] " Maxim Levitsky
2010-06-19 12:38 ` Bob Copeland
2010-06-19 13:02 ` Maxim Levitsky
2010-06-19 15:32 ` [PATCH v3] " Maxim Levitsky
2010-07-26 20:13 ` [ath5k-devel] " Luis R. Rodriguez
2010-07-26 20:49 ` Maxim Levitsky
2010-07-26 21:06 ` Luis R. Rodriguez
2010-07-26 21:14 ` Matthew Garrett
2010-07-26 22:20 ` Luis R. Rodriguez
2010-07-26 22:24 ` Matthew Garrett
2010-07-26 22:29 ` Luis R. Rodriguez
2010-07-26 21:17 ` Maxim Levitsky
2010-07-26 21:25 ` Matthew Garrett
2010-07-26 22:15 ` Luis R. Rodriguez
2010-07-26 22:21 ` Matthew Garrett
2010-07-26 22:26 ` Luis R. Rodriguez
2010-07-26 22:29 ` Matthew Garrett
2010-07-26 22:31 ` Luis R. Rodriguez
2010-07-26 22:33 ` Matthew Garrett
2010-07-26 22:43 ` Luis R. Rodriguez
2010-07-26 22:50 ` Matthew Garrett
2010-07-27 9:35 ` Maxim Levitsky
2010-07-27 15:57 ` Luis R. Rodriguez
2010-07-28 23:48 ` Maxim Levitsky [this message]
2010-07-29 0:06 ` Luis R. Rodriguez
2010-07-26 22:13 ` Luis R. Rodriguez
2010-07-26 22:56 ` Luis R. Rodriguez
2010-06-20 8:13 ` [ath5k-devel] [PATCH v2] " Luis R. Rodriguez
2010-06-20 11:18 ` Maxim Levitsky
2010-06-20 18:04 ` Maxim Levitsky
2010-06-21 5:53 ` Luis R. Rodriguez
2010-06-21 20:01 ` Jussi Kivilinna
2010-06-21 20:16 ` Maxim Levitsky
2010-06-21 20:33 ` Jussi Kivilinna
2010-06-21 20:39 ` Luis R. Rodriguez
2010-06-22 16:31 ` Matthew Garrett
2010-06-22 16:48 ` Luis R. Rodriguez
2010-06-22 16:52 ` Matthew Garrett
2010-06-22 17:17 ` Luis R. Rodriguez
2010-06-22 17:25 ` Matthew Garrett
2010-06-22 17:40 ` Luis R. Rodriguez
2010-06-22 17:50 ` Matthew Garrett
2010-06-22 18:28 ` Luis R. Rodriguez
2010-06-22 18:44 ` Matthew Garrett
2010-06-22 19:13 ` Luis R. Rodriguez
2010-06-22 19:31 ` Johannes Stezenbach
2010-06-22 19:37 ` Luis R. Rodriguez
2010-06-22 19:38 ` Luis R. Rodriguez
2010-06-23 14:39 ` Johannes Stezenbach
2010-06-23 16:28 ` Luis R. Rodriguez
2010-06-23 19:07 ` Johannes Stezenbach
2010-06-23 19:23 ` Johannes Stezenbach
2010-06-21 20:37 ` Luis R. Rodriguez
2010-06-21 23:55 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280360895.8891.19.camel@maxim-laptop \
--to=maximlevitsky@gmail.com \
--cc=David.Quan@atheros.com \
--cc=Luis.Rodriguez@atheros.com \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=jussi.kivilinna@mbnet.fi \
--cc=kernel-team@lists.ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@bombadil.infradead.org \
--cc=mcgrof@gmail.com \
--cc=mjg59@srcf.ucam.org \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox