Re: [patch 2/2] x86 NMI-safe INT3 and Page Fault

Avi Kivity
2010-07-16T18:33:23Z

On 07/16/2010 09:22 PM, Mathieu Desnoyers wrote:
>
>> There aren't that many processes at this time (or there shouldn't be,
>> don't know how fork-happy udev is at this stage), so the sync should be
>> pretty fast. In any case, we can sync only modules that contain NMI
>> handlers.
>>
> USB hotplug is a use-case happening randomly after the system is well there and
> running; I'm afraid this does not fit in your module loading expectations. It
> triggers tons of events, many of these actually load modules.
>

How long would vmalloc_sync_all take with a few thousand mm_struct take?

We share the pmds, yes? So it's a few thousand memory accesses. The
direct impact is probably negligible, compared to actually loading the
module from disk. All we need is to make sure the locking doesn't slow
down unrelated stuff.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.