From: Peter Zijlstra <peterz@infradead.org>
To: Borislav Petkov <bp@amd64.org>
Cc: acme@infradead.org, fweisbec@gmail.com, mingo@elte.hu,
rostedt@goodmis.org, linux-kernel@vger.kernel.org,
Borislav Petkov <borislav.petkov@amd.com>
Subject: Re: [RFC PATCH 4/9] mce: Add persistent events
Date: Fri, 06 Aug 2010 16:57:16 +0200 [thread overview]
Message-ID: <1281106636.1947.710.camel@laptop> (raw)
In-Reply-To: <1281104713-23141-5-git-send-email-bp@amd64.org>
On Fri, 2010-08-06 at 16:25 +0200, Borislav Petkov wrote:
> +static const struct file_operations perf_mce_fops = {
> + .llseek = no_llseek,
> + .open = mce_perf_open,
> + .poll = perf_poll,
> + .unlocked_ioctl = perf_ioctl,
> + .compat_ioctl = perf_ioctl,
> + .mmap = perf_mmap,
> + .fasync = perf_fasync,
> + .release = perf_release,
> +};
I'd rather see this part of the persistent bits live in
kernel/perf_event.c, that way you don't need the previous patch either.
next prev parent reply other threads:[~2010-08-06 14:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 14:25 [RFC PATCH 00/9] RAS daemon prototype, v2 Borislav Petkov
2010-08-06 14:25 ` [RFC PATCH 1/9] x86, mce: Notify about corrected events too Borislav Petkov
2010-08-06 14:25 ` [RFC PATCH 2/9] amd64_edac: Remove polling mechanism Borislav Petkov
2010-08-06 14:25 ` [RFC PATCH 3/9] perf_events: Export an assortment of functions Borislav Petkov
2010-08-06 14:25 ` [RFC PATCH 4/9] mce: Add persistent events Borislav Petkov
2010-08-06 14:57 ` Peter Zijlstra [this message]
2010-09-01 0:13 ` Steven Rostedt
2010-09-01 6:14 ` Ingo Molnar
2010-09-01 14:54 ` Steven Rostedt
2010-08-06 14:25 ` [RFC PATCH 5/9] perf: Move trace stuff into tools/lib/trace Borislav Petkov
2010-09-01 0:15 ` Steven Rostedt
2010-09-01 8:10 ` Borislav Petkov
2010-09-01 14:55 ` Steven Rostedt
2010-08-06 14:25 ` [RFC PATCH 6/9] perf: Export debugfs utilities Borislav Petkov
2010-08-06 14:25 ` [RFC PATCH 7/9] perf: Export cpumap Borislav Petkov
2010-08-06 14:39 ` Arnaldo Carvalho de Melo
2010-08-06 14:49 ` Borislav Petkov
2010-08-06 15:14 ` Arnaldo Carvalho de Melo
2010-08-06 16:04 ` Borislav Petkov
2010-08-06 21:48 ` Arnaldo Carvalho de Melo
2010-08-06 14:25 ` [RFC PATCH 8/9] perf: Carve out mmap helpers for general use Borislav Petkov
2010-08-06 14:25 ` [RFC PATCH 9/9] tools, ras: Add a RAS daemon Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281106636.1947.710.camel@laptop \
--to=peterz@infradead.org \
--cc=acme@infradead.org \
--cc=borislav.petkov@amd.com \
--cc=bp@amd64.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox