From: Artem Bityutskiy <dedekind1@gmail.com>
To: Don Mullis <don.mullis@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/6] lib/list_sort: test: use more reasonable printk levels
Date: Sat, 7 Aug 2010 11:10:41 +0300 [thread overview]
Message-ID: <1281168645-18413-3-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1281168645-18413-1-git-send-email-dedekind1@gmail.com>
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
I do not see any reason to use KERN_WARN for normal messages
and KERN_EMERG for error messages in the lib_sort testing routine.
Let's use more reasonable KERN_NORM and KERN_ERR levels.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
lib/list_sort.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/list_sort.c b/lib/list_sort.c
index 9dd8d4a..e0c2ccb 100644
--- a/lib/list_sort.c
+++ b/lib/list_sort.c
@@ -166,7 +166,7 @@ static int __init list_sort_test(void)
struct list_head *head = kmalloc(sizeof(*head), GFP_KERNEL);
struct list_head *cur;
- printk(KERN_WARNING "testing list_sort()\n");
+ printk(KERN_DEBUG "testing list_sort()\n");
cur = head;
for (i = 0; i < LIST_SORT_TEST_LENGTH; i++) {
@@ -189,17 +189,17 @@ static int __init list_sort_test(void)
struct debug_el *el = container_of(cur, struct debug_el, l_h);
int cmp_result = cmp(NULL, cur, cur->next);
if (cur->next->prev != cur) {
- printk(KERN_EMERG "list_sort() returned "
- "a corrupted list!\n");
+ printk(KERN_ERR "list_sort() returned "
+ "a corrupted list!\n");
return 1;
} else if (cmp_result > 0) {
- printk(KERN_EMERG "list_sort() failed to sort!\n");
+ printk(KERN_ERR "list_sort() failed to sort!\n");
return 1;
} else if (cmp_result == 0 &&
el->serial >= container_of(cur->next,
struct debug_el, l_h)->serial) {
- printk(KERN_EMERG "list_sort() failed to preserve order"
- " of equivalent elements!\n");
+ printk(KERN_ERR "list_sort() failed to preserve order "
+ "of equivalent elements!\n");
return 1;
}
kfree(cur->prev);
@@ -207,8 +207,8 @@ static int __init list_sort_test(void)
}
kfree(cur);
if (count != LIST_SORT_TEST_LENGTH) {
- printk(KERN_EMERG "list_sort() returned list of"
- "different length!\n");
+ printk(KERN_ERR "list_sort() returned list of "
+ "different length!\n");
return 1;
}
return 0;
--
1.7.1.1
next prev parent reply other threads:[~2010-08-07 8:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-07 8:10 [PATCH 0/6] improve list_sort test Artem Bityutskiy
2010-08-07 8:10 ` [PATCH 1/6] lib/Kconfig.debug: add list_sort debugging switch Artem Bityutskiy
2010-08-07 8:10 ` Artem Bityutskiy [this message]
2010-08-07 8:10 ` [PATCH 3/6] lib/list_sort: test: use generic random32 Artem Bityutskiy
2010-08-07 8:10 ` [PATCH 4/6] lib/list_sort: test: improve errors handling Artem Bityutskiy
2010-08-07 8:10 ` [PATCH 5/6] lib/list_sort: test: unify test messages Artem Bityutskiy
2010-08-07 8:10 ` [PATCH 6/6] lib/list_sort: test: check element addresses Artem Bityutskiy
2010-08-08 10:03 ` [PATCH 0/6] improve list_sort test Artem Bityutskiy
2010-08-08 19:31 ` Don Mullis
2010-08-08 20:07 ` Don Mullis
2010-08-09 5:59 ` Artem Bityutskiy
2010-08-21 9:56 ` Artem Bityutskiy
2010-08-21 10:03 ` Artem Bityutskiy
2010-08-21 10:06 ` [PATCH] lib/list_sort: do not pass bad pointers to cmp callback Artem Bityutskiy
2010-08-21 9:32 ` [PATCH 0/6] improve list_sort test Artem Bityutskiy
2010-08-21 10:22 ` Artem Bityutskiy
2010-08-21 16:59 ` don.mullis
2010-08-21 17:48 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281168645-18413-3-git-send-email-dedekind1@gmail.com \
--to=dedekind1@gmail.com \
--cc=don.mullis@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox